Uses the same format and plumbing as the existingallowForKnownSafePromises (#7008 ->#9186). The actual changes are pretty straightforward as a result.

Note that this doesn't yet addnode:test support, as that's blocked by#6861. I plan on sending a followup PR after this one goes in to fix that - usingProgram.sourceFileToPackageName if we really need.

Sending to thev8 branch instead ofmain because there are some project service fixes in there that this relies on. Example errors from targeting themain branch:https://github.com/typescript-eslint/typescript-eslint/actions/runs/9355798709/job/25751928593?pr=9234#logs. Update: or maybe those are also inv8. More investigation required.

💖

feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafePro…

1d3d648

…miseReturns' option

JoshuaKGoldberg requested a review fromkirkwaiblinger

June 3, 2024 18:31

Copy link

Contributor

typescript-eslintbot commentedJun 3, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ed8b7d9`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6660ddf11fdc350008020103
😎 Deploy Preview	https://deploy-preview-9234--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (🔴 down 8 from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJun 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commited8b7d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

test: always with the snapshots

9c15479

JoshuaKGoldberg commented

Jun 3, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-floating-promises.mdx Outdated

		</TabItem>
		<TabItemvalue="✅ Correct">

		```ts option='{"allowForKnownSafePromiseReturns":[{"from":"file","name":"safe","path":"input.ts"}]}' skipValidation

Copy link

MemberAuthor

JoshuaKGoldbergJun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

skipValidation

This was a fun one to discover:

The playground usesinput.ts
docs.test.ts usesfile.ts

I'm stepping out, but separate from this PR we should fix the two to be in sync.

Copy link

MemberAuthor

JoshuaKGoldbergJun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#9269 ->#9271

JoshuaKGoldberg removed the request for review fromkirkwaiblinger

June 3, 2024 19:15

JoshuaKGoldberg marked this pull request as draft

June 3, 2024 19:15

Merge branch 'v8' into no-floating-promises-allow-for-known-safe-prom…

e0fcd88

…ise-returns

JoshuaKGoldberg changed the base branch frommain tov8

June 3, 2024 20:55

JoshuaKGoldberg mentioned this pull request

Jun 4, 2024

Update reply.then and fastify.then types to use branded types to please typescript-eslintfastify/fastify#5498

Closed

JoshuaKGoldberg commented

Jun 4, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-floating-promises.test.tsShow resolvedHide resolved

fix unit test file relativity

54d380c

JoshuaKGoldberg marked this pull request as ready for review

June 4, 2024 19:48

JoshuaKGoldberg requested review froma team andkirkwaiblinger

June 4, 2024 19:48

kirkwaiblinger reviewed

Jun 4, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-floating-promises.mdxShow resolvedHide resolved

kirkwaiblinger reviewed

Jun 5, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

couple questions, no significant concerns.

packages/eslint-plugin/src/rules/no-floating-promises.tsShow resolvedHide resolved

packages/eslint-plugin/docs/rules/no-floating-promises.mdx OutdatedShow resolvedHide resolved

JoshuaKGoldberg added2 commits

June 5, 2024 11:10

Add .then test

c6da9d9

Update option name: allowForKnownSafeCalls

7eb4c3d

JoshuaKGoldberg requested a review fromkirkwaiblinger

June 5, 2024 15:51

JoshuaKGoldberg changed the title~~feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafePromiseReturns' option~~feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafeCalls' option

Jun 5, 2024

kirkwaiblinger requested changes

Jun 5, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just requesting a second look athttps://github.com/typescript-eslint/typescript-eslint/pull/9234/files#r1626760319 before it's good to go 🙂

Add .finally test

ed8b7d9

JoshuaKGoldberg requested a review fromkirkwaiblinger

June 5, 2024 21:52

kirkwaiblinger approved these changes

Jun 5, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jun 5, 2024

Copy link

codecovbot commentedJun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base(b4fbf6d) to head(ed8b7d9).
Report is 1 commits behind head on v8.

Additional details and impacted files

@@            Coverage Diff             @@##               v8    #9234      +/-   ##==========================================- Coverage   87.52%   87.49%   -0.04%==========================================  Files         387      386       -1       Lines       13197    13162      -35       Branches     3822     3814       -8     ==========================================- Hits        11551    11516      -35  Misses       1349     1349                Partials      297      297

Flag	Coverage Δ
unittest	`87.49% <100.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <100.00%> (ø)`

... and1 file with indirect coverage changes

JoshuaKGoldberg merged commit8e95924 intotypescript-eslint:v8

Jun 8, 2024

kirkwaiblinger mentioned this pull request

Jun 12, 2024

Enhancement: [no-floating-promises] add an 'allowForKnownSafeCalls' option#8404

Closed

4 tasks

github-actionsbot locked asresolvedand limited conversation to collaborators

Jun 17, 2024

JoshuaKGoldberg deleted the no-floating-promises-allow-for-known-safe-promise-returns branch

July 5, 2024 22:47

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafeCalls' option#9234

feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafeCalls' option#9234

Uh oh!

Conversation

JoshuaKGoldberg commentedJun 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJun 3, 2024

Uh oh!

netlifybot commentedJun 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJun 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

JoshuaKGoldbergJun 3, 2024

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergJun 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

codecovbot commentedJun 5, 2024

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoshuaKGoldberg commentedJun 3, 2024•
edited
Loading

netlifybot commentedJun 3, 2024•
edited
Loading

nx-cloudbot commentedJun 3, 2024•
edited
Loading