feat(typescript-estree): private identifiers can only appear on LHS of in expressions#9232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

Josh-Cena wants to merge1 commit intotypescript-eslint:main

base:main

Choose a base branch

fromJosh-Cena:private-binary-expr-ast-invariant

Draft

feat(typescript-estree): private identifiers can only appear on LHS of in expressions#9232

Josh-Cena wants to merge1 commit intotypescript-eslint:mainfromJosh-Cena:private-binary-expr-ast-invariant

Conversation

Copy link

Member

Josh-Cena commentedJun 3, 2024

PR Checklist

Addresses an existing open issue:fixesAST tightening:PrivateIdentifier can only be LHS ofBinaryExpression[operator='in'] #9222
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat(typescript-estree): private identifiers can only appear on LHS o…

1dc3d06

…f in expressions

Copy link

Contributor

typescript-eslintbot commentedJun 3, 2024

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`1dc3d06`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/665df4534bf34d0008457573
😎 Deploy Preview	https://deploy-preview-9232--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJun 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit1dc3d06. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution