Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): private identifiers can only appear on LHS of in expressions#9232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit546a854
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68e3b5eef92f0f00084e17c1
😎 Deploy Previewhttps://deploy-preview-9232--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🟢 up 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 3, 2024•
edited
Loading

View yourCI Pipeline Execution ↗ for commit546a854

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 2sView ↗
nx run-many -t lint✅ Succeeded3m 10sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx test typescript-estree --coverage=false✅ Succeeded20sView ↗
nx run generate-configs✅ Succeeded9sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-10-06 12:42:14 UTC

@Josh-CenaJosh-Cena marked this pull request as draftJune 3, 2024 17:14
@Josh-Cena
Copy link
MemberAuthor

Converting it to draft, because TS is very wack about private identifiers:console.log(#a) is also valid.

JoshuaKGoldberg reacted with laugh emojikirkwaiblinger reacted with eyes emoji

@JoshuaKGoldberg
Copy link
Member

👋 just checking in@Josh-Cena, is there anything we should do with this?

@JoshuaKGoldberg
Copy link
Member

Chatted 1:1, this is blocked on a resolution tomicrosoft/TypeScript#58754.

@JoshuaKGoldbergJoshuaKGoldberg added the blocked by another issueIssues which are not ready because another issue needs to be resolved first labelNov 10, 2024
@kirkwaiblinger
Copy link
Member

Since the TS fix has been languishing with no progress for over a year, can we just move forward with this on our side? Or do we need to keep this hard-blocked?

@JoshuaKGoldberg
Copy link
Member

Yeah, I think we should consider ourselves un-blocked at this point.

@JoshuaKGoldbergJoshuaKGoldberg removed the blocked by another issueIssues which are not ready because another issue needs to be resolved first labelSep 29, 2025
@codecovCodecov
Copy link

codecovbot commentedSep 29, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is23.07692% with10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.72%. Comparing base (9530e02) to head (546a854).
⚠️ Report is 39 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts23.07%10 Missing⚠️

❌ Your patch status has failed because the patch coverage (23.07%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #9232      +/-   ##==========================================- Coverage   90.93%   90.72%   -0.21%==========================================  Files         506      516      +10       Lines       51394    52027     +633       Branches     8482     8596     +114     ==========================================+ Hits        46735    47203     +468- Misses       4646     4810     +164- Partials       13       14       +1
FlagCoverage Δ
unittest90.72% <23.07%> (-0.21%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...s/ast-spec/src/expression/BinaryExpression/spec.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts31.12% <23.07%> (+0.89%)⬆️

... and30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 29, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! I think I'm mildly in favor of@kirkwaiblinger's suggestion, so I'll defer to you two on that. 🙂

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 29, 2025 16:28
Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 6, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitd29bd0a intotypescript-eslint:mainOct 6, 2025
65 of 66 checks passed
@Josh-CenaJosh-Cena deleted the private-binary-expr-ast-invariant branchOctober 6, 2025 13:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@kirkwaiblingerkirkwaiblingerkirkwaiblinger left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AST tightening:PrivateIdentifier can only be LHS ofBinaryExpression[operator='in']
3 participants
@Josh-Cena@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp