Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-floating-promises] add option 'allowForKnownSafePromises'#9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedMay 30, 2024•
edited
Loading

PR Checklist

Overview

This PR is a continuation of#8502, with a few finishing touches.

A big thank you to @arka1002, who is the primary author of this work! ❤️

Co-authored-by: @arka1002

arkapratimc and JoshuaKGoldberg reacted with heart emoji
'allowForKnownSafePromises' optionfixes:typescript-eslint#7008
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 30, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd391a04
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/665a5b789a49d20008d69e63
😎 Deploy Previewhttps://deploy-preview-9186--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 30, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd391a04. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewMay 30, 2024 23:19
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 31, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥 🔥 🔥

So pumped to see this land! I like how it ended up being a mostly additive change. This is great. Nice job @arka1002 +@kirkwaiblinger!

Nothing blocking from me - I'm happy to see this merged asap.

Skeleton putting on a pair of sunglasses on top of an oily moving background. Caption: "hell yeah"

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✅ 🤩 ❗❗❗

So excited to have this merged! Thanks!!

Marking as1 approval, with a calendar reminder on myself to merge Monday morning if no blocking feedback has been left by then!

Young Conan O'Brien in silly biker gear with greek wings on his helmet giving two 'rock on' signs. Caption: "LET'S ROCK AND ROLL"

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 2, 2024
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [no-floating-promises] add option 'allowForKnownSafePromises'feat(eslint-plugin): [no-floating-promises] add option 'allowForKnownSafePromises'Jun 3, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit04990d5 intotypescript-eslint:mainJun 3, 2024
63 of 64 checks passed
@kirkwaiblingerkirkwaiblinger deleted the kirk-safe-promises branchJune 3, 2024 14:44
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@arkapratimcarkapratimcarkapratimc approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-floating-promises] add an 'allowForKnownSafePromises' option
3 participants
@kirkwaiblinger@JoshuaKGoldberg@arkapratimc
[8]ページ先頭
©2009-2025 Movatter.jp