typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(rule-tester): re-apply updates from main#9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:v8fromJoshuaKGoldberg:v8-rule-tester-re-main

May 30, 2024

Merged

fix(rule-tester): re-apply updates from main#9180

JoshuaKGoldberg merged 3 commits intotypescript-eslint:v8fromJoshuaKGoldberg:v8-rule-tester-re-main

May 30, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedMay 30, 2024

PR Checklist

Addresses an existing open issue:fixes🐛 Bug: RuleTester updates reverted in v8 branch #9179
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Re-applies changes from#8883 - essentially undoing the accidentally reverts I'd applied.

Hooray, long-lived branches! 🙌

fix(rule-tester): re-apply updates from main

7f23e26

JoshuaKGoldberg requested review fromJamesHenry andauvred

May 30, 2024 14:42

Copy link

Contributor

typescript-eslintbot commentedMay 30, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 30, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`07cf874`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6658a72ed763680008b88e42
😎 Deploy Preview	https://deploy-preview-9180--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedMay 30, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit07cf874. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg added this to the8.0.0 milestone

May 30, 2024

bradzacher approved these changes

May 30, 2024

View reviewed changes

auvred requested changes

May 30, 2024

View reviewed changes

packages/rule-tester/tests/RuleTester.test.ts

		@@ -222,7 +221,6 @@ describe('RuleTester', () => {
		"parserOptions": {
		"disallowAutomaticSingleRunInference": true,
		"project": "tsconfig.test-specific.json",
		"projectService": false,
		"tsconfigRootDir": "/set/in/the/test/",
		},
		},

Copy link

Member

auvredMay 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like these lines“projectService”: false were added in#9084 (right before the bad merge commit). Do we really need to remove them? (I'm not 100% sure, just asking.)