Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: no-useless-template-expression -> no-unnecessary-template-expression#9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedMay 29, 2024•
edited
Loading

PR Checklist

Overview

followup to an unresolved comment in#8821

a sanity check QA pass for completeness is to check the regexno.?useless.?template.?expression does not match anywhere in the repo anymore (including for filenames)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitcf90a0d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6658decbc8dd86000823c2d2
😎 Deploy Previewhttps://deploy-preview-9174--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 29, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitcf90a0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@kirkwaiblingerkirkwaiblinger changed the titleno-useless-template-expression -> no-unnecessary-template-expressionfix: no-useless-template-expression -> no-unnecessary-template-expressionMay 29, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

📛

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 29, 2024
@kirkwaiblingerkirkwaiblinger merged commit26b95da intotypescript-eslint:mainMay 30, 2024
60 checks passed
@kirkwaiblingerkirkwaiblinger deleted the rename-to-no-unnecessary-template-expression branchMay 30, 2024 20:40
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@Josh-CenaJosh-CenaJosh-Cena approved these changes

Assignees

@kirkwaiblingerkirkwaiblinger

Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kirkwaiblinger@JoshuaKGoldberg@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp