Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-magic-numbers] fix implementation of theignore option#9167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Vinccool96
Copy link
Contributor

PR Checklist

Overview

As discussed in#9161, theignore option wasn't correctly implemented.

ignoreTypeIndexes was also added todefaultOptions since it was apparently missing.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

ikhtearalamshawonmollah54321 reacted with thumbs up emojiikhtearalamshawonmollah54321 reacted with hooray emojiikhtearalamshawonmollah54321 reacted with rocket emoji

@netlifyNetlify
Copy link

netlifybot commentedMay 28, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit02d78e9
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/665cbcb3cd854700085498e1
😎 Deploy Previewhttps://deploy-preview-9167--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 28, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit02d78e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@Vinccool96Vinccool96force-pushed thefix/no-magic-numbers-base-definition branch fromf084106 to79cbabdCompareMay 31, 2024 13:41
@codecovCodecov
Copy link

codecovbot commentedMay 31, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is75.00000% with3 lines in your changes are missing coverage. Please review.

Project coverage is 87.48%. Comparing base(50cc96d) to head(215b965).

❗Current head215b965 differs from pull request most recent head02d78e9

Pleaseupload reports for the commit02d78e9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #9167      +/-   ##==========================================- Coverage   87.49%   87.48%   -0.02%==========================================  Files         261      261                Lines       12709    12720      +11       Branches     3969     3977       +8     ==========================================+ Hits        11120    11128       +8  Misses       1310     1310- Partials      279      282       +3
FlagCoverage Δ
unittest87.48% <75.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts82.19% <75.00%> (-1.68%)⬇️

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Implementation looks great, thanks! I like the splitting out of the helpful functions. ✨

Requesting changes on thenode.value type shenanigans and a bit more granular testing please.

Vinccool96 reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJun 2, 2024
@Vinccool96Vinccool96force-pushed thefix/no-magic-numbers-base-definition branch from79cbabd to215b965CompareJune 2, 2024 14:56
}
`,
options: [{ ignoreNumericLiteralTypes: true, ignore: [1] }],
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] This is a perfect test 😁 tests one thing and is very clear. I like it!

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelJun 2, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 this is great! Thanks for massaging the tests a bunch!

Tom Hiddleston as Loki saying "Glorious"

Vinccool96 reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 2, 2024
@Vinccool96
Copy link
ContributorAuthor

LET'S GOOOOOOO
image

@github-actionsGitHub Actions
Copy link

Uh oh!@Vinccool96, the image you shared is missing helpful alt text. Check#9167 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically bygithub/accessibility-alt-text-bot.

Vinccool96 reacted with laugh emojiVinccool96 reacted with confused emoji

@JoshuaKGoldbergJoshuaKGoldberg merged commitbf5394d intotypescript-eslint:mainJun 6, 2024
62 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: no-magic-numbers Doesn't apply ignore to type definitions
2 participants
@Vinccool96@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp