Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse#9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Connormiha
Copy link
Contributor

I replacedmap +reduce with concat with singleflatMap.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Connormiha!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 20, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0ce70ba
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/664b128036cdfd00083da845
😎 Deploy Previewhttps://deploy-preview-9122--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 20, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0ce70ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@ConnormihaConnormiha changed the titlefix(naming-convention-utils): optimized normalizedOptions in parsefix(eslint-plugin): optimized normalizedOptions in parseMay 20, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool, thanks! ✨

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): optimized normalizedOptions in parsechore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parseMay 24, 2024
@JoshuaKGoldberg
Copy link
Member

Note that this is achore, not afix, as it's just an internal cleanliness thing. I would be shocked if there was ever any performance impact from a map/reduce -> flatMap in options parsing. 😄

@JoshuaKGoldbergJoshuaKGoldberg merged commitb5ce43b intotypescript-eslint:mainMay 24, 2024
60 of 64 checks passed
JoshuaKGoldberg added a commit that referenced this pull requestMay 24, 2024
…projectService (#9084)* feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService name as projectService* lil typo* Apply suggestions from code reviewCo-authored-by: auvred <61150013+auvred@users.noreply.github.com>* Fix snapshot too* A couple more experimental mentions* docs: [no-floating-promises] fix capitalization typo (#9118)capialization typoCo-authored-by: Joshua Chen <sidachen2003@gmail.com>* chore(release): publish 7.10.0* chore(eslint-plugin): replaced map/reduce with flatMap in normalizedOptions in parse (#9122)fix(naming-convention-utils): optimized normalizedOptions in parse* Add missing Parser.mdx options* Fix introduced type complaint---------Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>Co-authored-by: Joshua Chen <sidachen2003@gmail.com>Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>Co-authored-by: Mikhail <bodrovmiha@yandex.ru>
@Josh-Cena
Copy link
Member

This should berefactor, notchore btw—achore is something we do regularly like bumping deps or regenerating files

JoshuaKGoldberg reacted with thumbs up emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Connormiha@JoshuaKGoldberg@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp