Jul 6, 2024 · May 18, 2024 · May 21, 2024 · May 21, 2024 · May 22, 2024 · May 22, 2024
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
        run: yarn stylelint
        working-directory: packages/website

  eslint_v9_tests:
    name: Run tests on ESLint v9
    needs: [build]
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Install
        uses: ./.github/actions/prepare-install
        with:
          node-version: ${{ env.PRIMARY_NODE_VERSION }}
      - name: Build
        uses: ./.github/actions/prepare-build
      - run: yarn add eslint@9
      - name: Run tests
        run: yarn test
        env:
          CI: true

  integration_tests:
    name: Run integration tests on primary Node.js version
    needs: [build]
diff --git a/eslint.config.mjs b/eslint.config.mjs

 import url from 'node:url';

 import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
 import { FlatCompat } from '@eslint/eslintrc';
 import eslint from '@eslint/js';
 import tseslintInternalPlugin from '@typescript-eslint/eslint-plugin-internal';
    plugins: {
      ['@typescript-eslint']: tseslint.plugin,
      ['@typescript-eslint/internal']: tseslintInternalPlugin,
      ['deprecation']: deprecationPlugin,
      // https://github.com/gund/eslint-plugin-deprecation/issues/78
      // https://github.com/typescript-eslint/typescript-eslint/issues/8988
      ['deprecation']: fixupPluginRules(deprecationPlugin),
      ['eslint-comments']: eslintCommentsPlugin,
      ['eslint-plugin']: eslintPluginPlugin,
      ['import']: importPlugin,
      // https://github.com/import-js/eslint-plugin-import/issues/2948
      ['import']: fixupPluginRules(importPlugin),
      ['jest']: jestPlugin,
      ['jsdoc']: jsdocPlugin,
      ['jsx-a11y']: jsxA11yPlugin,
      ['react-hooks']: reactHooksPlugin,
      ['react']: reactPlugin,
      // https://github.com/facebook/react/issues/28313
      ['react-hooks']: fixupPluginRules(reactHooksPlugin),
      // https://github.com/jsx-eslint/eslint-plugin-react/issues/3699
      ['react']: fixupPluginRules(reactPlugin),
      ['simple-import-sort']: simpleImportSortPlugin,
      ['unicorn']: unicornPlugin,
    },
    files: ['packages/website/**/*.{ts,tsx,mts,cts,js,jsx}'],
    extends: [
      ...compat.config(jsxA11yPlugin.configs.recommended),
      ...compat.config(reactPlugin.configs.recommended),
      ...compat.config(reactHooksPlugin.configs.recommended),
      ...fixupConfigRules(compat.config(reactPlugin.configs.recommended)),
      ...fixupConfigRules(compat.config(reactHooksPlugin.configs.recommended)),
    ],
    rules: {
      '@typescript-eslint/internal/prefer-ast-types-enum': 'off',
diff --git a/package.json b/package.json
    "@babel/eslint-parser": "^7.24.1",
    "@babel/parser": "^7.24.4",
    "@babel/types": "^7.24.0",
    "@eslint/compat": "^1.0.1",
    "@eslint/eslintrc": "^2.1.4",
    "@eslint/js": "^8.57.0",
    "@jest/types": "29.6.3",
    "cross-fetch": "^4.0.0",
    "cspell": "^8.6.1",
    "downlevel-dts": ">=0.11.0",
    "eslint": "8.57.0",
    "eslint": "^9.3.0",
    "eslint-plugin-deprecation": "^2.0.0",
    "eslint-plugin-eslint-comments": "^3.2.0",
    "eslint-plugin-eslint-plugin": "^5.5.0",
    "@types/estree": "link:./tools/dummypkg",
    "@types/node": "^20.0.0",
    "@types/react": "^18.2.14",
    "eslint": "8.57.0",
    "eslint": "^9",
    "eslint-visitor-keys": "^3.4.1",
    "jest-config": "^29",
    "jest-resolve": "^29",
diff --git a/packages/eslint-plugin/rules.d.ts b/packages/eslint-plugin/rules.d.ts
 >;

 declare const rules: TypeScriptESLintRules;
 // eslint-disable-next-line import/no-default-export
 export default rules;
diff --git a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts
 /* eslint-disable @typescript-eslint/prefer-literal-enum-member */
 import type { TSESTree } from '@typescript-eslint/utils';
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 import * as tsutils from 'ts-api-utils';
diff --git a/packages/eslint-plugin/tests/rules/prefer-optional-chain/base-cases.ts b/packages/eslint-plugin/tests/rules/prefer-optional-chain/base-cases.ts
  ] as const;

 export const identity: MutateFn = c => c;
 /*
 eslint-disable-next-line eslint-plugin/prefer-message-ids, eslint-plugin/prefer-object-rule, eslint-plugin/require-meta-type, eslint-plugin/require-meta-schema --
 TODO - bug in hte rules - https://github.com/eslint-community/eslint-plugin-eslint-plugin/issues/455
 */
 export const BaseCases: BaseCaseCreator = ({
  operator,
  mutateCode = identity,
diff --git a/packages/eslint-plugin/tests/schema-snapshots/no-restricted-imports.shot b/packages/eslint-plugin/tests/schema-snapshots/no-restricted-imports.shot
diff --git a/packages/integration-tests/fixtures/markdown/.eslintrc.js b/packages/integration-tests/fixtures/markdown/.eslintrc.js
diff --git a/packages/integration-tests/fixtures/markdown/eslint.config.js b/packages/integration-tests/fixtures/markdown/eslint.config.js
 import markdown from 'eslint-plugin-markdown';
 import tseslint from 'typescript-eslint';

 export default tseslint.config(
  tseslint.configs.base,
  // this will also ensure that eslint will force lint the markdown files
  { plugins: { markdown }, files: ['**/*.md'], processor: 'markdown/markdown' },
  {
    files: ['**/*.md/*.{js,ts,jsx,tsx,javascript,node}'],
    rules: {
      '@typescript-eslint/no-explicit-any': 'error',
      'no-console': 'error',
    },
  },
 );
diff --git a/packages/integration-tests/fixtures/markdown/package.json b/packages/integration-tests/fixtures/markdown/package.json
 {
  "type": "module",
  "devDependencies": {
    "eslint-plugin-markdown": "latest"
  }
diff --git a/...ded-does-not-require-program/.eslintrc.js → ...does-not-require-program/eslint.config.js b/...ded-does-not-require-program/.eslintrc.js → ...does-not-require-program/eslint.config.js
 import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';

 // This integration test exists to make sure that the recommended config does
 // not require a program to be specified to ensure a fast and simple initial
 // setup. Users can add on one of our other configs if they want to opt in to
 // more expensive checks.
 module.exports = {
  root: true,
  parser: '@typescript-eslint/parser',
  extends: [
    'eslint:recommended',
    'plugin:@typescript-eslint/eslint-recommended',
    'plugin:@typescript-eslint/recommended',
  ],
  plugins: ['@typescript-eslint'],
 };
 export default tseslint.config(
  eslint.configs.recommended,
  ...tseslint.configs.recommended,
 );
diff --git a/packages/integration-tests/fixtures/recommended-does-not-require-program/package.json b/packages/integration-tests/fixtures/recommended-does-not-require-program/package.json
 {
  "type": "module",
  "devDependencies": {}
 }
diff --git a/packages/integration-tests/fixtures/vue-jsx/.eslintrc.js b/packages/integration-tests/fixtures/vue-jsx/.eslintrc.js
diff --git a/packages/integration-tests/fixtures/vue-jsx/eslint.config.js b/packages/integration-tests/fixtures/vue-jsx/eslint.config.js
 import tseslint from 'typescript-eslint';
 import pluginVue from 'eslint-plugin-vue';

 export default tseslint.config(
  tseslint.configs.base,
  ...pluginVue.configs['flat/essential'],
  {
    languageOptions: {
      parserOptions: { ecmaFeatures: { jsx: true }, parser: tseslint.parser },
    },
    rules: { '@typescript-eslint/no-explicit-any': 'error' },
  },
 );
diff --git a/packages/integration-tests/fixtures/vue-jsx/package.json b/packages/integration-tests/fixtures/vue-jsx/package.json
 {
  "type": "module",
  "devDependencies": {
    "vue-eslint-parser": "latest",
    "eslint-plugin-vue": "latest",
diff --git a/packages/integration-tests/fixtures/vue-sfc/.eslintrc.js b/packages/integration-tests/fixtures/vue-sfc/.eslintrc.js
diff --git a/packages/integration-tests/fixtures/vue-sfc/eslint.config.js b/packages/integration-tests/fixtures/vue-sfc/eslint.config.js
 import pluginVue from 'eslint-plugin-vue';
 import tseslint from 'typescript-eslint';

 export default tseslint.config(
  tseslint.configs.base,
  ...pluginVue.configs['flat/essential'],
  {
    languageOptions: {
      parserOptions: {
        parser: tseslint.parser,
        project: '/usr/linked/tsconfig.json',
      },
    },
    rules: {
      '@typescript-eslint/no-explicit-any': 'error',
      '@typescript-eslint/no-unnecessary-type-assertion': 'error',
      'semi-spacing': 'error',
    },
  },
 );
diff --git a/packages/integration-tests/fixtures/vue-sfc/package.json b/packages/integration-tests/fixtures/vue-sfc/package.json
 {
  "type": "module",
  "devDependencies": {
    "vue-eslint-parser": "latest",
    "eslint-plugin-vue": "latest",
diff --git a/...s/integration-tests/tests/__snapshots__/recommended-does-not-require-program.test.ts.snap b/...s/integration-tests/tests/__snapshots__/recommended-does-not-require-program.test.ts.snap
    "output": "const foo: unknown = true;
 ",
    "suppressedMessages": [],
    "usedDeprecatedRules": [
      {
        "replacedBy": [],
        "ruleId": "no-extra-semi",
      },
      {
        "replacedBy": [],
        "ruleId": "no-mixed-spaces-and-tabs",
      },
    ],
    "usedDeprecatedRules": [],
    "warningCount": 0,
  },
 ]
diff --git a/packages/integration-tests/tests/flat-config-types.test.ts b/packages/integration-tests/tests/flat-config-types.test.ts
    },
  );
 }
 eslintIntegrationTest(__filename, 'eslint.config.js', true);
 eslintIntegrationTest(__filename, 'eslint.config.js');
diff --git a/packages/integration-tests/tools/integration-test-base.ts b/packages/integration-tests/tools/integration-test-base.ts
 export function eslintIntegrationTest(
  testFilename: string,
  filesGlob: string,
  flatConfig = false,
 ): void {
  integrationTest('eslint', testFilename, async testFolder => {
    // lint, outputting to a JSON file
          'json',
          '--output-file',
          outFile,
          '--config',
          flatConfig ? './eslint.config.js' : './.eslintrc.js',
          '--fix-dry-run',
          filesGlob,
        ],
Original file line number	Diff line number	Diff line change
Expand Up		@@ -134,25 +134,6 @@ jobs:
		run: yarn stylelint
		working-directory: packages/website

		eslint_v9_tests:
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolved
		name: Run tests on ESLint v9
		needs: [build]
		runs-on: ubuntu-latest
		steps:
		- name: Checkout
		uses: actions/checkout@v4
		- name: Install
		uses: ./.github/actions/prepare-install
		with:
		node-version: ${{ env.PRIMARY_NODE_VERSION }}
		- name: Build
		uses: ./.github/actions/prepare-build
		- run: yarn add eslint@9
		- name: Run tests
		run: yarn test
		env:
		CI: true

		integration_tests:
		name: Run integration tests on primary Node.js version
		needs: [build]
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,6 +2,7 @@

		import url from 'node:url';

		import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
		import { FlatCompat } from '@eslint/eslintrc';
		import eslint from '@eslint/js';
		import tseslintInternalPlugin from '@typescript-eslint/eslint-plugin-internal';
Expand DownExpand Up		@@ -29,15 +30,20 @@ export default tseslint.config(
		plugins: {
		['@typescript-eslint']: tseslint.plugin,
		['@typescript-eslint/internal']: tseslintInternalPlugin,
		['deprecation']: deprecationPlugin,
		// https://github.com/gund/eslint-plugin-deprecation/issues/78
		// https://github.com/typescript-eslint/typescript-eslint/issues/8988
		['deprecation']: fixupPluginRules(deprecationPlugin),
abrahamguo marked this conversation as resolved. Show resolvedHide resolved
		['eslint-comments']: eslintCommentsPlugin,
		['eslint-plugin']: eslintPluginPlugin,
		['import']: importPlugin,
		// https://github.com/import-js/eslint-plugin-import/issues/2948
		['import']: fixupPluginRules(importPlugin),
Copy link Member bradzacherJun 23, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. we might want to consider switching to`eslint-plugin-import-x`? Copy link Member JoshuaKGoldbergJun 29, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'd be in support of this as a separate followup yeah.
		['jest']: jestPlugin,
		['jsdoc']: jsdocPlugin,
		['jsx-a11y']: jsxA11yPlugin,
		['react-hooks']: reactHooksPlugin,
		['react']: reactPlugin,
		// https://github.com/facebook/react/issues/28313
		['react-hooks']: fixupPluginRules(reactHooksPlugin),
		// https://github.com/jsx-eslint/eslint-plugin-react/issues/3699
		['react']: fixupPluginRules(reactPlugin),
		['simple-import-sort']: simpleImportSortPlugin,
		['unicorn']: unicornPlugin,
		},
Expand DownExpand Up		@@ -512,8 +518,8 @@ export default tseslint.config(
		files: ['packages/website/*/.{ts,tsx,mts,cts,js,jsx}'],
		extends: [
		...compat.config(jsxA11yPlugin.configs.recommended),
		...compat.config(reactPlugin.configs.recommended),
		...compat.config(reactHooksPlugin.configs.recommended),
		...fixupConfigRules(compat.config(reactPlugin.configs.recommended)),
		...fixupConfigRules(compat.config(reactHooksPlugin.configs.recommended)),
Comment on lines +521 to +522 Copy link Member bradzacherJun 23, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. it's so weird that we need to fixup the plugin both here and in the plugin def. seems like quite the flaw in the design of the compat tooling tbh Copy link ContributorAuthor abrahamguoJun 27, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @bradzacher that's actually not true. This can be removedif you are OK with me editing the section at the top of this file labeled`registering all the plugins up-front`, and removing any plugin for which we use a shared config (for example,`reactPlugin` and`reactHooksPlugin`). Shared configs automatically register their corresponding plugin, so it is unnecessary to manually register the plugin. The flip side, of course, would be if you felt that it's important to preserve a complete up-front list of all plugins used in any part of the config. If we choose to keep the complete up-front list of plugins, then the reason why we have to use the compat utilities twice, is because the plugins are defined twice (again, redundantly so), and we need to make sure that inboth places that each plugin is registered, it is the fixed-up version.
		],
		rules: {
		'@typescript-eslint/internal/prefer-ast-types-enum': 'off',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -60,6 +60,7 @@
		"@babel/eslint-parser": "^7.24.1",
		"@babel/parser": "^7.24.4",
		"@babel/types": "^7.24.0",
		"@eslint/compat": "^1.0.1",
		"@eslint/eslintrc": "^2.1.4",
		"@eslint/js": "^8.57.0",
		"@jest/types": "29.6.3",
Expand All		@@ -85,7 +86,7 @@
		"cross-fetch": "^4.0.0",
		"cspell": "^8.6.1",
		"downlevel-dts": ">=0.11.0",
		"eslint": "8.57.0",
		"eslint": "^9.3.0",
		"eslint-plugin-deprecation": "^2.0.0",
		"eslint-plugin-eslint-comments": "^3.2.0",
		"eslint-plugin-eslint-plugin": "^5.5.0",
Expand DownExpand Up		@@ -129,7 +130,7 @@
		"@types/estree": "link:./tools/dummypkg",
		"@types/node": "^20.0.0",
		"@types/react": "^18.2.14",
		"eslint": "8.57.0",
		"eslint": "^9",
		"eslint-visitor-keys": "^3.4.1",
		"jest-config": "^29",
		"jest-resolve": "^29",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -74,5 +74,4 @@ export type TypeScriptESLintRules = Record<
		>;

		declare const rules: TypeScriptESLintRules;
		// eslint-disable-next-line import/no-default-export
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolved
		export default rules;
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,3 @@
		/* eslint-disable @typescript-eslint/prefer-literal-enum-member */
		import type { TSESTree } from '@typescript-eslint/utils';
		import { AST_NODE_TYPES } from '@typescript-eslint/utils';
		import * as tsutils from 'ts-api-utils';
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -229,10 +229,6 @@ const RawBaseCases = (operator: '&&' \| '\|\|') =>
		] as const;

		export const identity: MutateFn = c => c;
		/*
		eslint-disable-next-line eslint-plugin/prefer-message-ids, eslint-plugin/prefer-object-rule, eslint-plugin/require-meta-type, eslint-plugin/require-meta-schema --
		TODO - bug in hte rules - https://github.com/eslint-community/eslint-plugin-eslint-plugin/issues/455
		*/
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolved
		export const BaseCases: BaseCaseCreator = ({
		operator,
		mutateCode = identity,
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,15 @@
		import markdown from 'eslint-plugin-markdown';
		import tseslint from 'typescript-eslint';

		export default tseslint.config(
		tseslint.configs.base,
		// this will also ensure that eslint will force lint the markdown files
		{ plugins: { markdown }, files: ['*/.md'], processor: 'markdown/markdown' },
		{
		files: ['*/.md/*.{js,ts,jsx,tsx,javascript,node}'],
		rules: {
		'@typescript-eslint/no-explicit-any': 'error',
		'no-console': 'error',
		},
		},
		);
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,5 @@
		{
		"type": "module",
		"devDependencies": {
		"eslint-plugin-markdown": "latest"
		}
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,14 +1,11 @@
		import eslint from '@eslint/js';
		import tseslint from 'typescript-eslint';

		// This integration test exists to make sure that the recommended config does
		// not require a program to be specified to ensure a fast and simple initial
		// setup. Users can add on one of our other configs if they want to opt in to
		// more expensive checks.
		module.exports = {
		root: true,
		parser: '@typescript-eslint/parser',
		extends: [
		'eslint:recommended',
		'plugin:@typescript-eslint/eslint-recommended',
		'plugin:@typescript-eslint/recommended',
		],
		plugins: ['@typescript-eslint'],
		};
		export default tseslint.config(
		eslint.configs.recommended,
		...tseslint.configs.recommended,
		);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,13 @@
		import tseslint from 'typescript-eslint';
		import pluginVue from 'eslint-plugin-vue';

		export default tseslint.config(
		tseslint.configs.base,
		...pluginVue.configs['flat/essential'],
		{
		languageOptions: {
		parserOptions: { ecmaFeatures: { jsx: true }, parser: tseslint.parser },
		},
		rules: { '@typescript-eslint/no-explicit-any': 'error' },
		},
		);