Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService#9084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMay 13, 2024•
edited
Loading

PR Checklist

Overview

Updates the naming and JSDoc-style comments around:

  • EXPERIMENTAL_useProjectService: simplifying it to justprojectService
  • allowDefaultProjectForFiles: simplifying it toallowDefaultProject
  • TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: updates it toTYPESCRIPT_ESLINT_PROJECT_SERVICE

This is in parallel to#8031, which will need to be updated after this.

Also filed a separate#9085 to update the rest of our docs. I think that'll end up needing more discussion, so I'd like to get this in sooner & first.

💖

acutmore reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@JoshuaKGoldbergJoshuaKGoldberg modified the milestones:v8,8.0.0May 13, 2024
@netlifyNetlify
Copy link

netlifybot commentedMay 13, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitaf60be8
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6650599367809400087dd18b
😎 Deploy Previewhttps://deploy-preview-9084--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 13, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitaf60be8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg requested review frombradzacher anda teamMay 13, 2024 00:46
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

projectService looks much better thanEXPERIMENTAL_useProjectService 😎

JoshuaKGoldberg reacted with laugh emoji
@auvredauvred added the awaiting responseIssues waiting for a reply from the OP or another party labelMay 13, 2024
JoshuaKGoldbergand others added3 commitsMay 13, 2024 08:00
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMay 13, 2024 15:02
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 13, 2024
@JoshuaKGoldbergJoshuaKGoldberg mentioned this pull requestMay 13, 2024
3 tasks
…nt#9118)capialization typoCo-authored-by: Joshua Chen <sidachen2003@gmail.com>
typescript-eslintbotand others added2 commitsMay 20, 2024 17:17
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like the typecheck CI job failed, but otherwise LGTM! 👍

https://cloud.nx.app/runs/MNTVtFbVly

@codecovCodecov
Copy link

codecovbot commentedMay 24, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base(87a0a48) to head(61a2c83).

❗Current head61a2c83 differs from pull request most recent headaf60be8

Pleaseupload reports for the commitaf60be8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@##               v8    #9084      +/-   ##==========================================- Coverage   87.46%   87.46%   -0.01%==========================================  Files         387      387                Lines       13117    13116       -1       Branches     3795     3795              ==========================================- Hits        11473    11472       -1  Misses       1354     1354                Partials      290      290
FlagCoverage Δ
unittest87.46% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...-estree/src/create-program/createProjectService.ts76.92% <ø> (ø)
...eate-program/validateDefaultProjectForFilesGlob.ts100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts80.28% <100.00%> (ø)
...escript-estree/src/useProgramFromProjectService.ts94.28% <ø> (-0.16%)⬇️

@JoshuaKGoldbergJoshuaKGoldberg merged commitb9796c1 intotypescript-eslint:v8May 24, 2024
60 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the project-service-finalize-naming branchMay 24, 2024 10:38
karlhorky added a commit to upleveled/preflight that referenced this pull requestMay 25, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@auvredauvredauvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

5 participants
@JoshuaKGoldberg@bradzacher@auvred@kirkwaiblinger@Connormiha
[8]ページ先頭
©2009-2025 Movatter.jp