Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(rule-tester): check for parsing errors in suggestion fixes#9052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

abrahamguo
Copy link
Contributor

@abrahamguoabrahamguo commentedMay 6, 2024•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Check for parsing errors in suggestion fixes. Ported from ESLint; seeeslint/eslint#16639

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita83ef1f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/664358872df2bf000869d8e8
😎 Deploy Previewhttps://deploy-preview-9052--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 6, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita83ef1f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@abrahamguoabrahamguo changed the titleenhancement(rule-tester): check for parsing errors in suggestion fixesfeat(rule-tester): check for parsing errors in suggestion fixesMay 6, 2024
@kirkwaiblinger
Copy link
Member

LGTM!
FYI, I modified the description to include a link to the ESLint reference PR.
seal of approval

kirkwaiblinger
kirkwaiblinger previously approved these changesMay 6, 2024
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 6, 2024
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@auvredauvred added the awaiting responseIssues waiting for a reply from the OP or another party labelMay 6, 2024
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 14, 2024
@bradzacherbradzacher added the enhancementNew feature or request labelMay 28, 2024
@bradzacher
Copy link
Member

@bradzacherbradzacher merged commita2e5479 intotypescript-eslint:mainMay 28, 2024
62 checks passed
@github-actionsGitHub Actions
Copy link

Uh oh!@bradzacher, the image you shared is missing helpful alt text. Check#9052 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text atBasic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically bygithub/accessibility-alt-text-bot.

bradzacher reacted with confused emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@auvredauvredAwaiting requested review from auvred

@kirkwaiblingerkirkwaiblingerAwaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement(rule-tester): check for parsing errors in suggestion fixes
4 participants
@abrahamguo@kirkwaiblinger@bradzacher@auvred
[8]ページ先頭
©2009-2025 Movatter.jp