feat(rule-tester): check for missing placeholder data in the message#9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromVinccool96:missing-placeholder-data

May 9, 2024

Merged

feat(rule-tester): check for missing placeholder data in the message#9039

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromVinccool96:missing-placeholder-data

May 9, 2024

Conversation

Copy link

Contributor

Vinccool96 commentedMay 2, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement(rule-tester): check for missing placeholder data in the message #9020
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Brings in changes fromeslint/eslint#18073. This is pretty much a copy & paste.

Enhancement(rule-tester): check for missing placeholder data in the m…

daaf6a8

…essage

Copy link

Contributor

typescript-eslintbot commentedMay 2, 2024

Thanks for the PR,@Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 2, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`daaf6a8`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6633aaf6be8f790008d73822
😎 Deploy Preview	https://deploy-preview-9039--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Vinccool96 changed the title~~Enhancement(rule-tester): check for missing placeholder data in the message~~feat(rule-tester): check for missing placeholder data in the message

May 2, 2024

Copy link

nx-cloudbot commentedMay 2, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitdaaf6a8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets