typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore: fix v8 branch snapshots for flat-config-types#9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:v8fromJoshuaKGoldberg:v8-flat-config-snapshot-fix

Apr 29, 2024

Merged

chore: fix v8 branch snapshots for flat-config-types#9029

JoshuaKGoldberg merged 2 commits intotypescript-eslint:v8fromJoshuaKGoldberg:v8-flat-config-snapshot-fix

Apr 29, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedApr 29, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: rule-tester tests failing on v8 #9012
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Ranyarn test -u in the package.

chore: fix v8 branch snapshots for flat-config-types

e7092a0

Copy link

Contributor

typescript-eslintbot commentedApr 29, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ce2a7ce`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/662f9cec514a7c0008ca24b0
😎 Deploy Preview	https://deploy-preview-9029--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 29, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitce2a7ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Check in the rest of them too

ce2a7ce

JoshuaKGoldberg commented

Apr 29, 2024

View reviewed changes

packages/integration-tests/tests/__snapshots__/flat-config-types.test.ts.snap

		@@ -16,7 +16,7 @@ exports[`flat-config-types eslint should work successfully 1`] = `
		"line": 38,
		"message": "'_otherCases' is defined but never used.",
		"messageId": "unusedVar",
		"nodeType":"Identifier",
		"nodeType":null,

Copy link

MemberAuthor

JoshuaKGoldbergApr 29, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I ... don't know why this is happening. None of the recentno-unused-vars ESLint PRs seem relevant. But the actual rule seems to work internally. 🤷

Copy link

Member

bradzacherApr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

8127873 /#8640

This commit changed thecontext.report from{ node, ... } to{ loc, ... }
Hence thenodeType is no longer visible in the output as the rule is not reporting against the node.