Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(rule-tester): portcheckDuplicateTestCases from ESLint#9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

PortscheckDuplicateTestCases from ESLint'sRuleTester.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3cf2411
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6655cdde2bd57b0008b3ed67
😎 Deploy Previewhttps://deploy-preview-9026--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 29, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3cf2411. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 29, 2024
@abrahamguo
Copy link
ContributorAuthor

@JoshuaKGoldberg should this be going intomain orv8?
I wasn't sure since in#8211@bradzacher mentioned this could be merged in ahead ofv8.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the port! 🙌

Just one suggestion on refactoring to a new file. If you don't like it I don't mind, and can merge as-is. Just let me know. 🙂

abrahamguo reacted with thumbs up emoji
@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg should this be going intomain orv8? I wasn't sure since in#8211@bradzacher mentioned this could be merged in ahead ofv8.

👍 Let's domain, as you have it. I had that wonder too. 😄

abrahamguo reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelApr 29, 2024
@abrahamguo
Copy link
ContributorAuthor

abrahamguo commentedApr 29, 2024•
edited
Loading

@JoshuaKGoldberg one curiosity question — how is this port ofRuleTester unit-tested? I was surprised to not see a copy of all ESLint's unit tests against this class, and that I didn't need to add any new tests for the port of this feature.

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 29, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

D'oh! Sorry, brain fart this morning - there should be tests. Seepackages/rule-tester/tests/eslint-base/eslint-base.test.js.

abrahamguo reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelApr 29, 2024
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamApril 30, 2024 20:13
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 30, 2024
@abrahamguo
Copy link
ContributorAuthor

There are about 10-20 rules ineslint-plugin which have duplicate tests. Most of them seem to be merging multiple combinations of auto-generated tests together. I'm working on fixing them, but let me know if you have any thoughts on that.

@bradzacherbradzacher added the enhancementNew feature or request labelMay 28, 2024
bradzacher
bradzacher previously approved these changesMay 28, 2024
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelsMay 28, 2024
@bradzacher
Copy link
Member

@abrahamguo just needs a rebase on main to resolve conflicts and we can merge this!

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 29, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit5ca7f6e intotypescript-eslint:mainJun 1, 2024
60 of 61 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancementNew feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement(rule-tester): detect duplicate test cases
3 participants
@abrahamguo@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp