Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(utils): allow specifying additional rule meta.docs in RuleCreator#9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 29, 2024
edited
Loading

BREAKING CHANGE:

Changes the default allowed types on custom rule docs.

PR Checklist

Overview

Adds an optionalPluginDocs type parameter toRuleCreator that allows adding additional properties tometa.docs. That allows us to moveextendsBaseRule,recommended, andrequiresTypeChecking into our ownESLintPluginDocs interface so that they're no longer exposed to consumers.

Adds newRuleModuleWithMetaDocs andAnyRuleModuleWithMetaDocs interfaces so that we can finally get rid of the?. aftermeta.docs in some of our internal tooling. AndRuleMetaDataDocs no longer has anOptions parameter, which simplifies some other types too.

Adds back in"layout" tometa.type as it actually is specified inhttps://eslint.org/docs/latest/extend/custom-rules.

💖

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 29, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 29, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb60b726
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/663be9aa205b920008cc753e
😎 Deploy Previewhttps://deploy-preview-9025--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 29, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb60b726. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(utils): [RuleCreator] require specifying additional rule meta.docsfeat(utils): require specifying additional rule meta.docs in RuleCreatorApr 29, 2024
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(utils): require specifying additional rule meta.docs in RuleCreatorfeat(utils): allow specifying additional rule meta.docs in RuleCreatorApr 29, 2024
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nodyes

@JoshuaKGoldbergJoshuaKGoldberg merged commitb1c92d4 intotypescript-eslint:v8May 9, 2024
57 of 58 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the rule-creator-custom-docs-types branchMay 9, 2024 00:15
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@JoshuaKGoldberg@JamesHenry@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp