May 12, 2024 · Apr 26, 2024 · Apr 26, 2024 · Apr 28, 2024 · Apr 28, 2024 · Apr 29, 2024
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
        run: yarn stylelint
        working-directory: packages/website

  eslint_v9_tests:
    name: Run tests on ESLint v9
    needs: [build]
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Install
        uses: ./.github/actions/prepare-install
        with:
          node-version: ${{ env.PRIMARY_NODE_VERSION }}
      - name: Build
        uses: ./.github/actions/prepare-build
      - run: yarn add eslint@9
      - name: Run tests
        run: yarn test
        env:
          CI: true

  integration_tests:
    name: Run integration tests on primary Node.js version
    needs: [build]
diff --git a/.../VariableDeclaration/fixtures/_error_/missing-value-in-using/snapshots/2-Babel-Error.shot b/.../VariableDeclaration/fixtures/_error_/missing-value-in-using/snapshots/2-Babel-Error.shot
diff --git a/...iableDeclaration/fixtures/_error_/missing-value-in-using/snapshots/3-Alignment-Error.shot b/...iableDeclaration/fixtures/_error_/missing-value-in-using/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/tests/fixtures-with-differences-errors.shot b/packages/ast-spec/tests/fixtures-with-differences-errors.shot
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
  },
  "peerDependencies": {
    "@typescript-eslint/parser": "^7.0.0",
    "eslint": "^8.57.0"
    "eslint": "^8.57.0 || ^9.0.0"
  },
  "peerDependenciesMeta": {
    "typescript": {
diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
  return output.join('\n').trim() + '\n';
 }

 const linter = new Linter();
 const linter = new Linter({ configType: 'eslintrc' });
 linter.defineParser('@typescript-eslint/parser', tseslintParser);

 const eslintOutputSnapshotFolder = path.resolve(
diff --git a/packages/eslint-plugin/tests/rules/array-type.test.ts b/packages/eslint-plugin/tests/rules/array-type.test.ts
 // -- eslint rule tester is not working with multi-pass
 // https://github.com/eslint/eslint/issues/11187
 describe('array-type (nested)', () => {
  const linter = new TSESLint.Linter();
  const linter = new TSESLint.Linter({ configType: 'eslintrc' });
  linter.defineRule('array-type', rule);
  linter.defineParser('@typescript-eslint/parser', parser);

diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts
  },
 });

 ruleTester.defineRule('use-every-a', context => {
  /**
   * Mark a variable as used
   */
  function useA(node: TSESTree.Node): void {
    context.sourceCode.markVariableAsUsed('a', node);
  }
  return {
    VariableDeclaration: useA,
    ReturnStatement: useA,
  };
 ruleTester.defineRule('use-every-a', {
  create: context => {
    /**
     * Mark a variable as used
     */
    function useA(node: TSESTree.Node): void {
      context.sourceCode.markVariableAsUsed('a', node);
    }
    return {
      VariableDeclaration: useA,
      ReturnStatement: useA,
    };
  },
  defaultOptions: [],
  meta: {
    messages: {},
    type: 'problem',
    schema: [],
  },
 });

 /**
diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
 };

 // this is used to ensure that the caching the utility does does not impact the results done by no-unused-vars
 ruleTester.defineRule('collect-unused-vars', context => {
  collectUnusedVariables(context);
  return {};
 ruleTester.defineRule('collect-unused-vars', {
  create(context) {
    collectUnusedVariables(context);
    return {};
  },
  defaultOptions: [],
  meta: {
    messages: {},
    type: 'problem',
    schema: [],
  },
 });

 ruleTester.run('no-unused-vars', rule, {
diff --git a/packages/parser/package.json b/packages/parser/package.json
    "typecheck": "tsc -p tsconfig.json --noEmit"
  },
  "peerDependencies": {
    "eslint": "^8.57.0"
    "eslint": "^8.57.0 || ^9.0.0"
  },
  "dependencies": {
    "@typescript-eslint/scope-manager": "7.8.0",
diff --git a/packages/rule-tester/package.json b/packages/rule-tester/package.json
  },
  "peerDependencies": {
    "@eslint/eslintrc": ">=2",
    "eslint": "^8.57.0"
    "eslint": "^8.57.0 || ^9.0.0"
  },
  "devDependencies": {
    "@types/lodash.merge": "4.6.9",
diff --git a/packages/rule-tester/src/RuleTester.ts b/packages/rule-tester/src/RuleTester.ts
 export class RuleTester extends TestFramework {
  readonly #testerConfig: TesterConfigWithDefaults;
  readonly #rules: Record<string, AnyRuleCreateFunction | AnyRuleModule> = {};
  readonly #linter: Linter = new Linter();
  readonly #linter: Linter = new Linter({ configType: 'eslintrc' });

  /**
   * Creates a new instance of RuleTester.
diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
    "rimraf": "*",
    "typescript": "*"
  },
  "peerDependencies": {
    "eslint": "^8.57.0"
  },
  "peerDependenciesMeta": {
    "typescript": {
      "optional": true
diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
    "test": "jest --coverage --passWithNoTests",
    "typecheck": "tsc -p tsconfig.json --noEmit"
  },
  "peerDependencies": {
    "eslint": "^8.57.0"
  },
  "dependencies": {
    "@typescript-eslint/eslint-plugin": "7.8.0",
    "@typescript-eslint/parser": "7.8.0",
diff --git a/packages/utils/package.json b/packages/utils/package.json
    "semver": "^7.6.0"
  },
  "peerDependencies": {
    "eslint": "^8.57.0"
    "eslint": "^8.57.0 || ^9.0.0"
  },
  "devDependencies": {
    "@typescript-eslint/parser": "7.8.0",
diff --git a/packages/utils/src/ts-eslint/Linter.ts b/packages/utils/src/ts-eslint/Linter.ts
    parserOptions?: ParserOptions;
  }

  // TODO - RuleCreateFunctionisno longersupported inESLintv9
  // TODO -removeRuleCreateFunctiononce weno longersupportESLint8
  export type LegacyPluginRules = Record<
    string,
    AnyRuleCreateFunction | AnyRuleModule
diff --git a/packages/utils/src/ts-eslint/Rule.ts b/packages/utils/src/ts-eslint/Rule.ts
 * @see {@link LooseParserModule}, {@link LooseProcessorModule}
 */
 export type LooseRuleDefinition =
  // TODO -ESLint v9 will removesupportfor RuleCreateFunction
  // TODO -remove RuleCreateFunction once we no longersupportESLint 8
  | LooseRuleCreateFunction
  | {
      meta?: object | undefined;
diff --git a/packages/website-eslint/src/index.js b/packages/website-eslint/src/index.js
 exports.esquery = esquery;

 exports.createLinter = function () {
  const linter = new Linter();
  const linter = new Linter({ configType: 'eslintrc' });
  for (const name in plugin.rules) {
    linter.defineRule(`@typescript-eslint/${name}`, plugin.rules[name]);
  }
diff --git a/packages/website-eslint/types/eslint.d.ts b/packages/website-eslint/types/eslint.d.ts
 cannot use VSCode's cache ever - stubbing it out permanently.
 */
 declare module 'eslint' {
  export interface LinterOptions {
    configType?: 'eslintrc';
  }
  export class Linter {
    constructor(options: LinterOptions);
    defineRule(name: string, rule: unknown): void;
  }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -134,6 +134,25 @@ jobs:
		run: yarn stylelint
		working-directory: packages/website

		eslint_v9_tests:
		name: Run tests on ESLint v9
		needs: [build]
		runs-on: ubuntu-latest
		steps:
		- name: Checkout
		uses: actions/checkout@v4
		- name: Install
		uses: ./.github/actions/prepare-install
		with:
		node-version: ${{ env.PRIMARY_NODE_VERSION }}
		- name: Build
		uses: ./.github/actions/prepare-build
		- run: yarn add eslint@9
		- name: Run tests
		run: yarn test
		env:
		CI: true

		integration_tests:
		name: Run integration tests on primary Node.js version
		needs: [build]
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -103,7 +103,7 @@
		},
		"peerDependencies": {
		"@typescript-eslint/parser": "^7.0.0",
		"eslint": "^8.57.0"
		"eslint": "^8.57.0 \|\| ^9.0.0"
		},
		"peerDependenciesMeta": {
		"typescript": {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -100,7 +100,7 @@ function renderLintResults(code: string, errors: Linter.LintMessage[]): string {
		return output.join('\n').trim() + '\n';
		}

		const linter = new Linter();
		const linter = new Linter({ configType: 'eslintrc' });
		linter.defineParser('@typescript-eslint/parser', tseslintParser);

		const eslintOutputSnapshotFolder = path.resolve(
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1924,7 +1924,7 @@ interface FooInterface {
		// -- eslint rule tester is not working with multi-pass
		// https://github.com/eslint/eslint/issues/11187
		describe('array-type (nested)', () => {
		const linter = new TSESLint.Linter();
		const linter = new TSESLint.Linter({ configType: 'eslintrc' });
		linter.defineRule('array-type', rule);
		linter.defineParser('@typescript-eslint/parser', parser);

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,17 +16,25 @@ const ruleTester = new RuleTester({
		},
		});

		ruleTester.defineRule('use-every-a', context => {
		/**
		* Mark a variable as used
		*/
		function useA(node: TSESTree.Node): void {
		context.sourceCode.markVariableAsUsed('a', node);
		}
		return {
		VariableDeclaration: useA,
		ReturnStatement: useA,
		};
		ruleTester.defineRule('use-every-a', {
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolved
		create: context => {
		/**
		* Mark a variable as used
		*/
		function useA(node: TSESTree.Node): void {
		context.sourceCode.markVariableAsUsed('a', node);
		}
		return {
		VariableDeclaration: useA,
		ReturnStatement: useA,
		};
		},
		defaultOptions: [],
		meta: {
		messages: {},
		type: 'problem',
		schema: [],
		},
		});

		/**
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,9 +20,17 @@ const withMetaParserOptions = {
		};

		// this is used to ensure that the caching the utility does does not impact the results done by no-unused-vars
		ruleTester.defineRule('collect-unused-vars', context => {
		collectUnusedVariables(context);
		return {};
		ruleTester.defineRule('collect-unused-vars', {
		create(context) {
		collectUnusedVariables(context);
		return {};
		},
		defaultOptions: [],
		meta: {
		messages: {},
		type: 'problem',
		schema: [],
		},
		});

		ruleTester.run('no-unused-vars', rule, {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -49,7 +49,7 @@
		"typecheck": "tsc -p tsconfig.json --noEmit"
		},
		"peerDependencies": {
		"eslint": "^8.57.0"
		"eslint": "^8.57.0 \|\| ^9.0.0"
		},
		"dependencies": {
		"@typescript-eslint/scope-manager": "7.8.0",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -56,7 +56,7 @@
		},
		"peerDependencies": {
		"@eslint/eslintrc": ">=2",
		"eslint": "^8.57.0"
		"eslint": "^8.57.0 \|\| ^9.0.0"
		},
		"devDependencies": {
		"@types/lodash.merge": "4.6.9",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -76,7 +76,7 @@ let defaultConfig = deepMerge(
		export class RuleTester extends TestFramework {
		readonly #testerConfig: TesterConfigWithDefaults;
		readonly #rules: Record<string, AnyRuleCreateFunction \| AnyRuleModule> = {};
		readonly #linter: Linter = new Linter();
		readonly #linter: Linter = new Linter({ configType: 'eslintrc' });

		/**
		* Creates a new instance of RuleTester.
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -60,9 +60,6 @@
		"rimraf": "*",
		"typescript": "*"
		},
		"peerDependencies": {
		"eslint": "^8.57.0"
		},
		"peerDependenciesMeta": {
		"typescript": {
		"optional": true
Expand Down