Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support ESLint v9#9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 26, 2024•
edited
Loading

👉NOTE: This is into ourv8 branch. Once it's merged, it'll only be included in ourv8 versions.

PR Checklist

Overview

Keeps us on ESLint v8 internally, but adds v9 to the supported version ranges. Adds a CI check thatyarn add eslint@9; yarn test passes.

jhoermann and javelinco reacted with thumbs up emojipi0, kirillgroshkov, auvred, sreetamdas, altsalt, anthonyshew, javelinco, patricebender, reduckted, NachoToast, and 2 more reacted with heart emojicurtgrimes, javelinco, and bsal649 reacted with eyes emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftApril 26, 2024 13:40
@netlifyNetlify
Copy link

netlifybot commentedApr 26, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitee1d91c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/663ce10214bbb100085ba99f
😎 Deploy Previewhttps://deploy-preview-9002--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 26, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitee1d91c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome! LGTM 🏆

JoshuaKGoldberg, Volerous, dbirks, kirillgroshkov, No1ceTea, pommelinho, Yokozuna59, and ArnoldZokas reacted with heart emoji
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

question: do we really want to do the bump to v9 if it completely breaks our lint setup like this?
would we be better served by instead just adding a decent integration test which runs against v9, and leaving our setup on v8 for now?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I ranyarn dedupe to trim this file down a bit. Then I reverted thetmp upgrades as they cause a few odd CI failures.#8589

@RobinTail

This comment has been minimized.

@JoshuaKGoldbergJoshuaKGoldberg merged commitb765f7b intotypescript-eslint:v8May 12, 2024
62 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the eslint-9 branchMay 12, 2024 23:30
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedMay 13, 2024•
edited
Loading

Now that this is merged, thev8 versions of typescript-eslint starting withv8.0.0-alpha.10 now support ESLint v9. Hooray! 🙌

If you still have problems with typescript-eslint and ESLint v9:

  1. Please make sure you're usingtypescript-eslint@8.0.0-alpha.10 or newer
  2. Go throughour issue chooser to file a new issue reporting your problems
    • That issue template includessearching for existing issues matching your problem - please do not file duplicate issues

Note that we do not plan on backporting ESLint v9 support to v7 versions of typescript-eslint. There are a lot of breaking changes inherent to our ESLint v9 support.

If any enterprising individual wants to try onboardingus in typescript-eslint to ESLint v9,#9082 tracks that as a followup.

reduckted, mdouglass, Silvenga, controversial, hyoban, sreetamdas, JstnMcBrd, RobinTail, rchukh, erik-krogh, and 11 more reacted with hooray emojiSilvenga, controversial, RobinTail, atjn, zalizko, altsalt, dbirks, and J3m5 reacted with heart emoji

@auvredauvred mentioned this pull requestMay 13, 2024
26 tasks
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@karlhorkykarlhorkykarlhorky left review comments

@auvredauvredauvred approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@JoshuaKGoldberg@RobinTail@karlhorky@bradzacher@auvred
[8]ページ先頭
©2009-2025 Movatter.jp