Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(rule-tester): assert suggestion messages are unique#8995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 25, 2024
edited
Loading

PR Checklist

Overview

Brings in changes fromeslint/eslint#17532. This is pretty much a copy & paste.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedApr 25, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita6d1af0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run integration-tests:test
✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewApril 26, 2024 01:01
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 26, 2024
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamApril 26, 2024 01:01
@bradzacher
Copy link
Member

BREAKING CHANGE:
Adds extra validation to rule-tester.

sir#8969

Per the discussion in that thread, we'd like to not treat this as a breaking change

bradzacher
bradzacher previously approved these changesApr 26, 2024
@auvred
Copy link
Member

Oh, looks likerule-tester is not tested in CI:

package:
[
'ast-spec',
'eslint-plugin',
'eslint-plugin-internal',
'parser',
'repo-tools',
'rule-schema-to-typescript-types',
'scope-manager',
'type-utils',
'typescript-eslint',
'typescript-estree',
'utils',
'visitor-keys',
]

I also tried to runyarn run test-eslint-base locally and got a bunch of test failures related to deprecated in ESLint v9 stuff. What do you think about syncingtests/eslint-base/eslint-base.test.js andtests/eslint-base/fixtures/* with upstream? It looks like some fixtures have been changed in v9 as well.

JoshuaKGoldberg reacted with thumbs up emoji

@JoshuaKGoldberg
Copy link
MemberAuthor

sir#8969

Per the discussion in that thread, we'd like to not treat this as a breaking change

Oh! I missed that 🤦 excellent. In that case I'll switch this to be againstmain and consider#8211 as having all required issues blocked. I sent#9002 to start working on ESLint 9 range support on thev8 branch.

@JoshuaKGoldbergJoshuaKGoldbergforce-pushed therule-tester-unique-suggestions branch fromc29e3c2 toa6d1af0CompareApril 26, 2024 14:11
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch fromv8 tomainApril 26, 2024 14:11
@JoshuaKGoldbergJoshuaKGoldberg dismissedbradzacher’sstale reviewApril 26, 2024 14:11

The base branch was changed.

@netlify
Copy link

netlifybot commentedApr 26, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita6d1af0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/662bb60585ab0c000815b2fb
😎 Deploy Previewhttps://deploy-preview-8995--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldberg
Copy link
MemberAuthor

Oh, looks likerule-tester is not tested in CI:

😂.#9005. Good spot!

tried to run yarn run test-eslint-base locally and got a bunch of test failures related to deprecated in ESLint v9 stuff

Ooh, yes, that too. Since you have it locally - would you be up for filing that? I'm kind of flitting between things.

@JoshuaKGoldbergJoshuaKGoldberg merged commit277ee38 intotypescript-eslint:mainApr 28, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the rule-tester-unique-suggestions branchApril 28, 2024 16:00
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshuaKGoldberg@bradzacher@auvred

[8]ページ先頭

©2009-2025 Movatter.jp