feat(utils): swap LegacyESLint out for FlatESLint as ESLint export#8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:v8fromJoshuaKGoldberg:utils-swap-flateslint-legacyeslint

Apr 26, 2024

Merged

feat(utils): swap LegacyESLint out for FlatESLint as ESLint export#8972

JoshuaKGoldberg merged 3 commits intotypescript-eslint:v8fromJoshuaKGoldberg:utils-swap-flateslint-legacyeslint

Apr 26, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedApr 22, 2024•
edited
Loading

BREAKING:
Changes the names of exports.

PR Checklist

Addresses an existing open issue:fixesEnhancement(utils): Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API #8970
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Applies just a quick export name change so importingESLint gives youFlatESLint, notLegacyESLint.

Also updates theTODO comment to reflect keeping the legacy class around.

💖

feat(utils): swap LegacyESLint out for FlatESLint as ESLint export

707aa76

Copy link

Contributor

typescript-eslintbot commentedApr 22, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg added the breaking changeThis change will require a new major version to be released label

Apr 22, 2024

JoshuaKGoldberg added this to the8.0.0 milestone

Apr 22, 2024

Copy link

nx-cloudbot commentedApr 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita0d223f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets