typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [no-unused-vars] align catch behavior to ESLint 9#8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:eslint-9-no-unused-vars

Apr 26, 2024

Merged

feat(eslint-plugin): [no-unused-vars] align catch behavior to ESLint 9#8971

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:eslint-9-no-unused-vars

Apr 26, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedApr 22, 2024•
edited
Loading

BREAKING CHANGE:
Changes the default behavior of a rule.

PR Checklist

Addresses an existing open issue:fixesEnhancement: [no-unused-vars] Update for ESLint 9 defaults #8967
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Roughly applies the same changes fromeslint/eslint#17932 andeslint/eslint#18043.

💖

feat(eslint-plugin): [no-unused-vars] align catch behavior to ESLint 9

dac72a2

Copy link

Contributor

typescript-eslintbot commentedApr 22, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 22, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`dac72a2`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6626c72b48232f0008573e9a
😎 Deploy Preview	https://deploy-preview-8971--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg added this to the8.0.0 milestone

Apr 22, 2024

JoshuaKGoldberg changed the base branch frommain tov8

April 22, 2024 20:23

JoshuaKGoldberg force-pushed thev8 branch from5eba5ef to61c2ee7Compare

April 22, 2024 20:24

Copy link

nx-cloudbot commentedApr 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitdac72a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets