Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(type-utils)!: remove IsNullableTypeOptions interface#8934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

thuchede
Copy link
Contributor

PR Checklist

Overview

Remove@deprecatedIsNullableTypeOptions interface and its usage inisNullableType

JoshuaKGoldbergand others added2 commitsApril 15, 2024 10:56
…typescript-eslint#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
typescript-eslint#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@thuchede!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 16, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite970b12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@thuchedethuchedeforce-pushed theremove-is-nullable-type-options branch from1a2afe5 to6bd6595CompareApril 16, 2024 03:42
@thuchedethuchede changed the titlechore!(type-utils): remove IsNullableTypeOptions interfacechore(type-utils)!: remove IsNullableTypeOptions interfaceApr 16, 2024
@auvredauvred added the breaking changeThis change will require a new major version to be released labelApr 19, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great thanks! 🚀

@JoshuaKGoldbergJoshuaKGoldberg merged commitf4cbbe6 intotypescript-eslint:v8Apr 23, 2024
2 checks passed
@JoshuaKGoldberg
Copy link
Member

Whoops, I forgot to addBREAKING CHANGE: to the start of this PR's description. Noting to self that we'll need to manually edit this into the changelog.

@bradzacher
Copy link
Member

@JoshuaKGoldberg you also left the! in the title which might break the semantic generator!

@JoshuaKGoldberg
Copy link
Member

😬.

@bradzacher
Copy link
Member

We probably need to see if we can configure the PR title action to ban the!

JoshuaKGoldberg reacted with thumbs up emoji

@JoshuaKGoldberg
Copy link
Member

#9027

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 7, 2024
@JoshuaKGoldberg
Copy link
Member

#9789, too 📝

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@thuchede@JoshuaKGoldberg@bradzacher@auvred
[8]ページ先頭
©2009-2025 Movatter.jp