Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript-estree): rename automaticSingleRunInference to disallowAutomaticSingleRunInference#8922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 15, 2024
edited
Loading

BREAKING:
Switches the name and default behavior of a parsing option.

PR Checklist

Overview

RenamesallowAutomaticSingleRunInference todisallowAutomaticSingleRunInference, so that we can keep to having no options enabled by default. The "happy path" is for users to never interact with this option: it should "just" be on and working by default.

Manually specifiesdisallowAutomaticSingleRunInference in quite a few Jest tests that work with manual parsing. Turns out sharing that state can really mess up some tests.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 15, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitdd20f36
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/661da4c3057ff90008a52bd6
😎 Deploy Previewhttps://deploy-preview-8922--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 15, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitda356bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov8April 22, 2024 20:41
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(typescript-estree): disallowAutomaticSingleRunInference, off (fast) by defaultfeat(typescript-estree): rename automaticSingleRunInference to disallowAutomaticSingleRunInferenceApr 22, 2024
@JoshuaKGoldbergJoshuaKGoldberg added the breaking changeThis change will require a new major version to be released labelApr 22, 2024
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 22, 2024
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewApril 22, 2024 21:19
@JoshuaKGoldbergJoshuaKGoldberg merged commit5650142 intotypescript-eslint:v8Apr 26, 2024
55 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the single-run-inference-by-default branchApril 26, 2024 13:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Default allowAutomaticSingleRunInference to true
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp