Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body#8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 14, 2024•
edited
Loading

BREAKING CHANGE:
Deprecates an existing property on the AST

PR Checklist

Overview

MarksTSEnumDeclaration'smembers property as@deprecated in favor of a newbody property of a new typeTSEnumBody. Adds a getter with similarprocess.emitWarning logic to our existing deprecated getters.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 14, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit48b32bc
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/661c48aa98a4270008b3f76e
😎 Deploy Previewhttps://deploy-preview-8920--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 14, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit56f6af5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov8April 14, 2024 22:23
},
],
errors: [{ messageId: 'after', type: AST_TOKEN_TYPES.Block, line: 3 }],
},
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This rule is being removed in#8833 anyway. I didn't feel like fixing up bugs in it. 🔪

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewApril 15, 2024 11:42
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelApr 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

note: we're deleting this in v8

JoshuaKGoldberg reacted with thumbs up emoji
JoshuaKGoldbergand others added3 commitsApril 15, 2024 10:29
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commitfaa74c5 intotypescript-eslint:v8Apr 15, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the ts-enum-body branchApril 15, 2024 15:22
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* remove getTypeArguments* one lil '---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull requestApr 23, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* chore(type-utils)!: remove IsNullableTypeOptions interface---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 23, 2024
@bradzacherbradzacher added this to the8.0.0 milestoneJun 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Align AST for TSEnumDeclaration with TSInterfaceDeclaration, TSModuleDeclaration, etc
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp