Movatterモバイル変換

Skip to content

typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): fix crash in rule indent for eslint 5.12.1#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

JamesHenry merged 1 commit intotypescript-eslint:masterfromarmano2:indent-crash

Jan 20, 2019

Merged

fix(eslint-plugin): fix crash in rule indent for eslint 5.12.1#89

JamesHenry merged 1 commit intotypescript-eslint:masterfromarmano2:indent-crash

Jan 20, 2019

Conversation

armano2

Copy link

Collaborator

armano2 commentedJan 20, 2019•
edited
Loading

This PR fixes crash of indent rule when used with eslint 5.12.11 and makes sure thatno-unused-vars has messages copied from parent rule (not used yet)

this is related toeslint/eslint#10773

fixes:#80
fixes:#96

@armano2

fix(eslint-plugin): fix crash in rule indent for eslint 5.12.1

522d920

eslint/eslint#10773

@codecov

Copy link

codecovbot commentedJan 20, 2019•
edited
Loading

Codecov Report

Merging#89 intomaster willnot change coverage.
The diff coverage isn/a.

@@          Coverage Diff           @@##           master     #89   +/-   ##======================================  Coverage    94.8%   94.8%           ======================================  Files          48      48             Lines        2465    2465             Branches      380     380           ======================================  Hits         2337    2337             Misses         77      77             Partials       51      51

Impacted Files	Coverage Δ
packages/eslint-plugin/lib/rules/indent.js	`100% <ø> (ø)`	⬆️
packages/eslint-plugin/lib/rules/no-unused-vars.js	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedbd27c5...522d920. Read thecomment docs.

JamesHenry

JamesHenry approved these changes

View reviewed changes

@JamesHenry

JamesHenry merged commit3f51d51 intotypescript-eslint:master

@armano2

armano2 deleted the indent-crash branch

January 20, 2019 14:30

armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request

@timothykang

@JamesHenry

Fix: Mark call expression type parameters as used (typescript-eslint#89)

56d3b46

@github-actions

github-actionsbot locked asresolvedand limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

None yet

2 participants

@armano2

@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp