Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): replaceno-new-symbol withno-new-native-nonconstructor#8895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

reduckted
Copy link
Contributor

PR Checklist

Overview

See:

ESLint'sno-new-symbol rule was deprecated and replaced withno-new-native-nonconstructor. This PR disablesno-new-native-nonconstructor instead of disablingno-new-symbol.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@reduckted!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 10, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7833624
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/661d30f24937c40009128418
😎 Deploy Previewhttps://deploy-preview-8895--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 10, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit7833624. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for now - we'll need to disable both rules.
we still support ESLint v8 - so if we drop the old rule then we'll no longer work correctly for those users!
Otherwise LGTM!

reduckted reacted with thumbs up emoji
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bradzacherbradzacher added the enhancementNew feature or request labelApr 15, 2024
@bradzacherbradzacher merged commitfda5704 intotypescript-eslint:mainApr 15, 2024
5 of 6 checks passed
@bradzacherbradzacher mentioned this pull requestApr 15, 2024
42 tasks
@reducktedreduckted deleted the feature/update-eslint-recommended branchApril 15, 2024 20:19
JoshuaKGoldberg added a commit that referenced this pull requestApr 19, 2024
* feat(eslint-plugin): remove formatting/layout rules* Remove "layout"* feat(typescript-estree): add defaultProject for project service (#8815)* feat(typescript-estree): add defaultProject for project service* Thanks Jake, service.setCompilerOptionsForInferredProjects* Cleaned up a bit and added happy path testing* Update packages/typescript-estree/src/parser-options.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* feat(eslint-plugin): replace `no-new-symbol` with `no-new-native-nonconstructor` (#8895)Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* Add tombstones* 'deprecated' typo* Let's mention both issues* Fix unused variable issue---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>Co-authored-by: Dave <reduckted@outlook.com>
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
* feat(eslint-plugin): remove formatting/layout rules* Remove "layout"* feat(typescript-estree): add defaultProject for project service (#8815)* feat(typescript-estree): add defaultProject for project service* Thanks Jake, service.setCompilerOptionsForInferredProjects* Cleaned up a bit and added happy path testing* Update packages/typescript-estree/src/parser-options.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* feat(eslint-plugin): replace `no-new-symbol` with `no-new-native-nonconstructor` (#8895)Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* Add tombstones* 'deprecated' typo* Let's mention both issues* Fix unused variable issue---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>Co-authored-by: Dave <reduckted@outlook.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@reduckted@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp