classClazz{// beforeprivateshouldBeReadonly=()=>{/* ... */};~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~// afterprivateshouldBeReadonly=()=>{/* ... */};~~~~~~~~~~~~~~~~~~~~~~~~}

Copy link

Contributor

typescript-eslintbot commentedApr 10, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 10, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9f3e403`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/665fd6d0e26f1c0008492af7
😎 Deploy Preview	https://deploy-preview-8894--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (🔴 down 8 from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

kirkwaiblinger commented

Apr 10, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-readonly.ts Outdated

		* out in front of the key, and the key itself, but not anything afterwards,
		* i.e. parens, type annotations, method bodies, or `?`.
		*/
		function getReportLoc(

Copy link

MemberAuthor

kirkwaiblingerApr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

extract and reuse utilities from#8869

Copy link

nx-cloudbot commentedApr 10, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9f3e403. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

kirkwaiblinger changed the title~~[prefer-readonly] Refine report locations~~fix(eslint-plugin): [prefer-readonly] Refine report locations

Apr 10, 2024

kirkwaiblinger changed the title~~fix(eslint-plugin): [prefer-readonly] Refine report locations~~fix(eslint-plugin): [prefer-readonly] refine report locations

Apr 10, 2024

yeonjuan mentioned this pull request

Apr 10, 2024

Enhancement: Improve lint error report location#8543

Closed

9 tasks

kirkwaiblinger force-pushed theprefer-readonly-report-loc branch fromfa24b6b tob5cad08Compare

April 10, 2024 07:31

kirkwaiblinger added blocked by another PR

PRs which are ready to go but waiting on another PR

enhancementNew feature or request labels

May 4, 2024

kirkwaiblinger removed the blocked by another PRPRs which are ready to go but waiting on another PR label

May 29, 2024

Copy link

MemberAuthor

kirkwaiblinger commentedMay 30, 2024•
edited
Loading

#8869 has been merged now, so I'll work on this soon to open it up for review

JoshuaKGoldberg previously approved these changes

Jun 2, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM in theory, nice@kirkwaiblinger! Is this ready for merge frommain now that#8869 is merged?

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jun 2, 2024

Copy link

MemberAuthor

kirkwaiblinger commentedJun 3, 2024

@JoshuaKGoldberg Not quite yet. I have a branch on my machine which does that and incorporates#8869. Just need to clean it up slightly before pushing and undrafting.

kirkwaiblinger added3 commits

June 4, 2024 19:51

[prefer-readonly] Refine report locations

cfaa642

wip

df3759d

bring stuff to shared code

c963914

kirkwaiblinger dismissedJoshuaKGoldberg’sstale review viac963914

June 5, 2024 02:04

kirkwaiblinger force-pushed theprefer-readonly-report-loc branch fromb5cad08 toc963914Compare

June 5, 2024 02:04

kirkwaiblinger commented

Jun 5, 2024

View reviewed changes

packages/eslint-plugin/src/rules/explicit-member-accessibility.ts

		* out in front of the key, and the key itself, but not anything afterwards,
		* i.e. parens, type annotations, method bodies, or `?`.
		*/
		function getMissingAccessibilityReportLoc(