Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(rule-tester): support multipass fixes#8883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 8 commits intotypescript-eslint:v8fromauvred:feat-8554
May 16, 2024

Conversation

auvred
Copy link
Member

PR Checklist

Overview

kirkwaiblinger reacted with thumbs up emojikirkwaiblinger reacted with hooray emojikirkwaiblinger reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 8, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0a92776
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66336ce9b60d6c00080b9f1c
😎 Deploy Previewhttps://deploy-preview-8883--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 8, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0a92776. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@auvredauvred changed the base branch frommain tov8April 8, 2024 16:23
@auvredauvred changed the base branch fromv8 tomainApril 8, 2024 16:24
@auvredauvred changed the base branch frommain tov8April 8, 2024 16:27
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks lovely to me - and great test cases too!

I think@bradzacher will want to take a look too if he has time, given that he wrote a bunch on the feature requests.

Big Boss from Metal Gear nodding goofily at a computer, then turning to the camera and giving a thumbs up

auvred reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelApr 23, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one small suggestion, looks great to me! 🔥

auvred reacted with rocket emoji
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ILOVE this feature! ❤️

Approved pending resolution of comments, which may not require any changes at all. If you do make changes, I think they're simple enough that you have carte blanche from me to merge without an explicit reapproval from me.

auvred reacted with heart emoji
auvredand others added2 commitsMay 2, 2024 13:34
@JoshuaKGoldbergJoshuaKGoldberg merged commit5c80828 intotypescript-eslint:v8May 16, 2024
56 of 58 checks passed
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneMay 24, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[rule-tester] support multipass fixes
3 participants
@auvred@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp