Apr 22, 2024 · Apr 7, 2024
diff --git a/packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx b/packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx

 ### `ignoreConditionalTests`

 Setting this option to `true` will cause the rule toignore any cases that are located within a conditional test. This is set to `false` by default.
 Setting this option to `false` will cause the rule toalso check cases that are located within a conditional test. This is set to `true` by default.

 Generally expressions within conditional tests intentionally use the falsy fallthrough behavior of the logical or operator, meaning that fixing the operator to the nullish coalesce operator could cause bugs.

diff --git a/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts b/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts
  defaultOptions: [
    {
      allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
      ignoreConditionalTests:false,
      ignoreConditionalTests:true,
      ignoreTernaryTests: false,
      ignoreMixedLogicalExpressions: false,
      ignorePrimitives: {
diff --git a/packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts b/packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts
 declare const x: ${type} | ${nullish};
 x || 'foo' ? null : null;
      `,
      options: [{ ignoreConditionalTests: true }],
    })),
    ...nullishTypeValidTest((nullish, type) => ({
      code: `
 declare const x: ${type} | ${nullish};
 if (x || 'foo') {}
      `,
      options: [{ ignoreConditionalTests: true }],
    })),
    ...nullishTypeValidTest((nullish, type) => ({
      code: `
 declare const x: ${type} | ${nullish};
 do {} while (x || 'foo')
      `,
      options: [{ ignoreConditionalTests: true }],
    })),
    ...nullishTypeValidTest((nullish, type) => ({
      code: `
 declare const x: ${type} | ${nullish};
 for (;x || 'foo';) {}
      `,
      options: [{ ignoreConditionalTests: true }],
    })),
    ...nullishTypeValidTest((nullish, type) => ({
      code: `
 declare const x: ${type} | ${nullish};
 while (x || 'foo') {}
      `,
      options: [{ ignoreConditionalTests: true }],
    })),

    // ignoreMixedLogicalExpressions
 if (() => x || 'foo') {}
      `,
      output: null,
      options: [{ ignoreConditionalTests: true }],
      errors: [
        {
          messageId: 'preferNullishOverOr',
 if (function werid() { return x || 'foo' }) {}
      `,
      output: null,
      options: [{ ignoreConditionalTests: true }],
      errors: [
        {
          messageId: 'preferNullishOverOr',
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,7 +65,7 @@ foo ?? 'a string';

		### `ignoreConditionalTests`

		Setting this option to `true` will cause the rule toignore any cases that are located within a conditional test. This is set to `false` by default.
		Setting this option to `false` will cause the rule toalso check cases that are located within a conditional test. This is set to `true` by default.

		Generally expressions within conditional tests intentionally use the falsy fallthrough behavior of the logical or operator, meaning that fixing the operator to the nullish coalesce operator could cause bugs.

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -100,7 +100,7 @@ export default createRule<Options, MessageIds>({
		defaultOptions: [
		{
		allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
		ignoreConditionalTests:false,
		ignoreConditionalTests:true,
		ignoreTernaryTests: false,
		ignoreMixedLogicalExpressions: false,
		ignorePrimitives: {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -147,35 +147,30 @@ x === null ? x : y;
		declare const x: ${type} \| ${nullish};
		x \|\| 'foo' ? null : null;
		`,
		options: [{ ignoreConditionalTests: true }],
		})),
		...nullishTypeValidTest((nullish, type) => ({
		code: `
		declare const x: ${type} \| ${nullish};
		if (x \|\| 'foo') {}
		`,
		options: [{ ignoreConditionalTests: true }],
		})),
		...nullishTypeValidTest((nullish, type) => ({
		code: `
		declare const x: ${type} \| ${nullish};
		do {} while (x \|\| 'foo')
		`,
		options: [{ ignoreConditionalTests: true }],
		})),
		...nullishTypeValidTest((nullish, type) => ({
		code: `
		declare const x: ${type} \| ${nullish};
		for (;x \|\| 'foo';) {}
		`,
		options: [{ ignoreConditionalTests: true }],
		})),
		...nullishTypeValidTest((nullish, type) => ({
		code: `
		declare const x: ${type} \| ${nullish};
		while (x \|\| 'foo') {}
		`,
		options: [{ ignoreConditionalTests: true }],
		})),

		// ignoreMixedLogicalExpressions
Expand DownExpand Up		@@ -706,7 +701,6 @@ declare const x: ${type} \| ${nullish};
		if (() => x \|\| 'foo') {}
		`,
		output: null,
		options: [{ ignoreConditionalTests: true }],
		errors: [
		{
		messageId: 'preferNullishOverOr',
Expand All		@@ -732,7 +726,6 @@ declare const x: ${type} \| ${nullish};
		if (function werid() { return x \|\| 'foo' }) {}
		`,
		output: null,
		options: [{ ignoreConditionalTests: true }],
		errors: [
		{
		messageId: 'preferNullishOverOr',
Expand Down