I'd considered renaming the option tocheckConditionalTests so we could avoid having a truthy default... but figured that was a bit more user effort than folks are likely to want. I'd be happy to make that change if requested though.

💖

feat(eslint-plugin): [prefer-nullish-coalescing] change ignoreConditi…

c344d37

…onalTests default to true

Copy link

Contributor

typescript-eslintbot commentedApr 7, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 7, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c344d37`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66129ba1dd2b26000814361d
😎 Deploy Preview	https://deploy-preview-8872--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 7, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc344d37. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg marked this pull request as ready for review

April 7, 2024 13:22

kirkwaiblinger approved these changes

Apr 21, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lgtm. Yay!

Regarding the description, I don't see a reason to change the name of the option.... People that have already specified the option manually will get to keep their configuration, rather than being punished with a broken lint run just because we changed our minds about a default. And people who have not specified it will be impacted identically independently of whether the name is changed.