typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [explicit-member-accessibility] refine report locations#8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 7 commits intotypescript-eslint:mainfromkirkwaiblinger:explicit-member-accessibility-report-loc

May 28, 2024

Merged

fix(eslint-plugin): [explicit-member-accessibility] refine report locations#8869

bradzacher merged 7 commits intotypescript-eslint:mainfromkirkwaiblinger:explicit-member-accessibility-report-loc

May 28, 2024

Conversation

Copy link

Member

kirkwaiblinger commentedApr 7, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue: fixespartiallyEnhancement: Improve lint error report location #8543
That issue was marked asaccepting prs
Steps inContributing were taken

cc@developer-bandi

Overview

This PR makes it so that formissing accessibility modifiers, we report just the symbol name preceeded by however many keywords (get,abstract, etc)

classA{// before   @foo^^^^getx():string{^^^^^^^^^^^^^^^^^^^^}^^^^// after   @foogetx():string{^^^^^}}

and forpublic modifiers that shouldnot be present, weonly flag on thepublic keyword itself

classA{// beforepublicabstractmethod(x:string):number;^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^// afterpublicabstractmethod(x:string):number;^^^^^^}

[explicit-member-accessibility] Refine report locations.

9d3c8af

Copy link

Contributor

typescript-eslintbot commentedApr 7, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 7, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`602de2a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66346bc010dc4e0008d40e11
😎 Deploy Preview	https://deploy-preview-8869--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 7, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit602de2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

kirkwaiblinger marked this pull request as ready for review

April 7, 2024 01:57

kirkwaiblinger commented

Apr 7, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts

		suggestions: [
		{
		messageId: 'addExplicitAccessibility',
		data: { type: 'public' },
		output: `
		class Test {
		public constructor(public...x: any[]) {}
		public constructor(public x: any[]) {}

Copy link

MemberAuthor

kirkwaiblingerApr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

changed this since it's illegal syntax for a parameter property to be a rest element. Though the rule doesn't really care.

kirkwaiblinger commented

Apr 7, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts

Copy link

MemberAuthor

kirkwaiblingerApr 7, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i audited everyinvalid test case and put in the exact report range, since it wasvery helpful for development to do so. I realize, however, that that may be overkill for testing (and can make modifications to the rule or test cases unnecessarily unwieldy). If requested, I can remove some of the added report locations. But IMO they might as well stay now that they're there

Copy link

Member

bradzacherMay 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Eventually we'll have#6994 and we can kill all of the line/col assertions.

yeonjuan mentioned this pull request

Apr 7, 2024

Enhancement: Improve lint error report location#8543

Closed

9 tasks

Copy link

Member

Josh-Cena commentedApr 7, 2024

@kirkwaiblinger If you don't want to auto-close that issue, you have to make sure your description doesn't contain the substring "fixes #xxx". You can say "fixes (partially) #xxx" (I usually do that)