feat(utils): add types for both flat and legacy eslint classes#8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intomainfromeslint-v9-eslint-classes

Apr 8, 2024

Merged

feat(utils): add types for both flat and legacy eslint classes#8861

bradzacher merged 2 commits intomainfromeslint-v9-eslint-classes

Apr 8, 2024

+622 −389

Conversation

Copy link

Member

bradzacher commentedApr 6, 2024

PR Checklist

Addresses an existing open issue:ESLint v9 Support #8211
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Add types for the newFlatESlint class.
Rename and export types for theLegacyESLint class.
Deprecate the existingESLint class.
Add missing types from the docs.

bradzacher added the enhancementNew feature or request label

Apr 6, 2024

Copy link

Contributor

typescript-eslintbot commentedApr 6, 2024

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

add types for both flat and legacy eslint classes

84abbfc

Copy link

netlifybot commentedApr 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e6f03b6`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66132240737aa30008b1699a
😎 Deploy Preview	https://deploy-preview-8861--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

bradzacher force-pushed theeslint-v9-eslint-classes branch from49156e1 to84abbfcCompare

April 6, 2024 04:45

Copy link

nx-cloudbot commentedApr 6, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite6f03b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets