Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): remove slow deprecated and isolated programs#8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 4, 2024•
edited
Loading

BREAKING CHANGE: Removes public API option around default programs.

PR Checklist

Overview

Removes program creation specific to the two linked issues. I found thatcreateProjectProgram was only returningundefined whenparseSettings.DEPRECATED__createDefaultProgram was truthy, which was howgetProgramAndAST would fall back to an isolated program. Hence tackling both in the same PR.

💖

armano2 reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2004a86
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/660e0f5f533e9f0008337891
😎 Deploy Previewhttps://deploy-preview-8834--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 4, 2024
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5c740df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov8April 4, 2024 02:33
@codecovCodecov
Copy link

codecovbot commentedApr 4, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base(984f4cd) to head(2004a86).
Report is 40 commits behind head on v8.

❗ Current head2004a86 differs from pull request most recent head5c740df. Consider uploading reports for the commit5c740df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##               v8    #8834      +/-   ##==========================================+ Coverage   88.02%   88.04%   +0.01%==========================================  Files         405      404       -1       Lines       14089    14068      -21       Branches     4125     4120       -5     ==========================================- Hits        12402    12386      -16+ Misses       1382     1378       -4+ Partials      305      304       -1
FlagCoverage Δ
unittest88.04% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...-estree/src/create-program/createProjectProgram.ts100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts78.87% <ø> (ø)

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewApril 6, 2024 15:48
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelApr 15, 2024
…gram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commit8253e21 intotypescript-eslint:v8Apr 15, 2024
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
…#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* remove getTypeArguments* one lil '---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull requestApr 23, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)* feat(typescript-estree): remove slow deprecated and isolated programs* Update packages/typescript-estree/src/create-program/createProjectProgram.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body* Fixed up tests and their snapshots* More about enums* Indent too* Update packages/ast-spec/src/special/TSEnumBody/spec.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* parent types touchups* Update packages/visitor-keys/src/visitor-keys.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>* chore(type-utils)!: remove IsNullableTypeOptions interface---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Refactor: Remove createIsolatedProgram call from getProgramAndAST Refactor: Investigate removing Program from isolated programs
3 participants
@JoshuaKGoldberg@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp