Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

☁️ Nx Cloud Report

CI is running/has finished running commands for commit94a530d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 fromNxCloud.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base(716b783) to head(5702dc2).
Report is 27 commits behind head on v8.

❗ Current head5702dc2 differs from pull request most recent head94a530d. Consider uploading reports for the commit94a530d to get more accurate results

@@            Coverage Diff             @@##               v8    #8833      +/-   ##==========================================- Coverage   88.02%   86.42%   -1.61%==========================================  Files         405      234     -171       Lines       14089    11423    -2666       Branches     4125     3575     -550     ==========================================- Hits        12402     9872    -2530+ Misses       1382     1291      -91+ Partials      305      260      -45

seems good to me

Delete it all. Yes. Die.

The only suggestion I would have: likecamelcase - I think it would be best to leave tombstones behind to forward people to the new rules.

Why? Because people running on older versions will "click to open docs" in their IDE and it will open our site tohttps://typescript-eslint.io/rules/block-spacing/. They'll get a 404 page and be completely confused and probably file an issue.

Or they'll be using ESLint v8 and noticecomma-dangle doesn't work as expected with TS constructs and they'll search our repo for a replacement (as is the standard when looking for extension rules) and find no existing rule -then request it cos they didn't read any other docs.

It'll cost us nothing to keep tombstones around but it'll help orient people and cut off useless support requests.

what do you think about releasing old version of docs athttps://v7.typescript-eslint.io/, that would let ppl who still use old version have access to it

@armano2 we could do that. The problem there is discoverability - the rules are setup to link directly totypescript-eslint.io/rules/rule-name so if someone uses the "open docs" command then they're not gonna see the legacy docs.

I'm personally not too miffed about older versions losing docs - it's going to be a small fraction of users that actively need the old docs.
Each time this has been brought up in the past our collective response has been "it's just not worth the effort".