Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): deprecate no-loss-of-precision extension rule#8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedApr 4, 2024•
edited
Loading

BREAKING CHANGE: Removes the rule from recommended-type-checked.

PR Checklist

Overview

Deprecates the rule and removes it fromrecommended.

💖

kirkwaiblinger reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0bb64bc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedApr 4, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base(716b783) to head(f029bda).
Report is 27 commits behind head on v8.

❗ Current headf029bda differs from pull request most recent head0bb64bc. Consider uploading reports for the commit0bb64bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##               v8    #8832      +/-   ##==========================================- Coverage   88.02%   87.37%   -0.65%==========================================  Files         405      255     -150       Lines       14089    12511    -1578       Branches     4125     3927     -198     ==========================================- Hits        12402    10932    -1470+ Misses       1382     1304      -78+ Partials      305      275      -30
FlagCoverage Δ
unittest87.37% <ø> (-0.65%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...es/eslint-plugin/src/rules/no-loss-of-precision.ts100.00% <ø> (ø)

... and150 files with indirect coverage changes

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 4, 2024
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cast it into the fire!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelApr 18, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit5eba5ef intotypescript-eslint:v8Apr 22, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the deprecate-no-loss-of-precision branchApril 22, 2024 17:55
JoshuaKGoldberg added a commit that referenced this pull requestApr 22, 2024
…8832)* feat(eslint-plugin): deprecate no-loss-of-precision extension rule* baseRule.create, nice Kirk
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp