Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-useless-template-literals] rename tono-useless-template-expression (deprecateno-useless-template-literals)#8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedApr 2, 2024•
edited
Loading

PR Checklist

Overview

Copy old rule to new rule.
Deprecate rule under old name.
Lots of documentation updating.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 2, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4829797
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66423646c9a00b0008679c2c
😎 Deploy Previewhttps://deploy-preview-8821--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 2, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4829797. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@kirkwaiblingerkirkwaiblinger changed the titleRename no-useless-template-literals to no-useless-template-expressionfix(eslint-plugin): [no-useless-template-literals] rename to no-useless-template-expressionApr 2, 2024
@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewApril 2, 2024 04:01
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneApr 14, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM in general! Just requesting changes on some docs touchups (the suggestions). Nothing functionally blocking from me. Thanks! ✨

kirkwaiblinger reacted with thumbs up emoji
@kirkwaiblinger
Copy link
MemberAuthor

@JoshuaKGoldberg
This is a super last-minute thought, but I wonder whether we should soften it to "no-unnecessary-template-expression" instead of "no-useless-template-expression". The other no-useless-* rules are true noops that can be removed entirely, whereas this is just code that could be simplified. More in line with the no-unnecessary-* rules. We did plenty of bikeshedding on the "template-expression"/"template-interpolation"/"template-substitution" part of the rule in#8544, but didn't give the first half any thought. Not that it was the part of the name that was motivating to change, of course.

@JoshuaKGoldberg
Copy link
Member

no-unnecessary-template-expression

I'm up for theno-unnecesssary preference, that's a good distinction. Thoughts@Josh-Cena ?

@@ -16,10 +16,10 @@ This rule restricts what can be thrown as an exception.

:::warning
This rule is being renamed to [`only-throw-error`](./only-throw-error.mdx).
When it was first created, it only prevented literals from being thrown (hence the name), but it has now been expanded to only allow expressions which have a possibility of being an `Error` object.
With the `allowThrowingAny` and `allowThrowingUnknown` options, it can be configured to only allow throwing values which are guaranteed to be an instance of `Error`.
The current name, `no-throw-literal`, will be removed in a future major version of typescript-eslint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

since this PR changes multiple rules, maybe we should also change its title?
(so it'll also be squashed with the proper commit message)

or maybe split tp multiple PRs?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This comes out of#8821 (comment).
I think it makes sense to include in this change set since it's such a small (and related) change.

StyleShit reacted with thumbs up emoji

## When Not To Use It

When you want to allow string expressions inside template literals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IIRC, it's not only for strings, it's also for other literals such as numbers, booleans, null, etc.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, true. That part of the PR is just unchanged code moved fromthe existing page, though. See on main:

##When Not To Use It
When you want to allow string expressions inside template literals.

I don't feel strongly about it, so I would prefer not to bother changing it in this PR 🙃. Feel free to submit a separate PR to change that line if you like! 🙂

JoshuaKGoldberg reacted with thumbs up emoji
Comment on lines +74 to +78
:::info
This rule does not aim to flag template literals without substitution expressions that could have been written as an ordinary string.
That is to say, this rule will not help you turn `` `this` `` into `"this"`.
If you are looking for such a rule, you can configure the [`@stylistic/ts/quotes`](https://eslint.style/rules/ts/quotes) rule to do this.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Like it!

kirkwaiblinger and JoshuaKGoldberg reacted with heart emoji
@codecovCodecov
Copy link

codecovbot commentedMay 13, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base(f53fece) to head(12182f5).
Report is 13 commits behind head on main.

❗Current head12182f5 differs from pull request most recent head4829797

Pleaseupload reports for the commit4829797 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8821      +/-   ##==========================================- Coverage   88.04%   87.39%   -0.66%==========================================  Files         410      256     -154       Lines       14187    12522    -1665       Branches     4136     3927     -209     ==========================================- Hits        12491    10943    -1548+ Misses       1391     1304      -87+ Partials      305      275      -30
FlagCoverage Δ
unittest87.39% <100.00%> (-0.66%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...plugin/src/rules/no-useless-template-expression.ts100.00% <100.00%> (ø)
...t-plugin/src/rules/no-useless-template-literals.ts100.00% <100.00%> (ø)

... and189 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 sorry for the delay, this is great!

I'm happy for you to merge whenever you're comfortable with it.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 26, 2024
@bradzacherbradzacher changed the titlefix(eslint-plugin): [no-useless-template-literals] rename to no-useless-template-expressionfeat(eslint-plugin): [no-useless-template-literals] rename tono-useless-template-expression (deprecateno-useless-template-literals)May 28, 2024
@bradzacherbradzacher merged commit09ecbe2 intotypescript-eslint:mainMay 28, 2024
59 checks passed
@kirkwaiblingerkirkwaiblinger deleted the rename-no-useless-template-literal branchMay 29, 2024 06:45
@Eugeno
Copy link

"no-useless-template-expression" was renamed to "no-unnecessary-template-expression", but in the release note:

eslint-plugin: [no-useless-template-literals] rename to no-useless-template-expression (deprecate no-useless-template-literals) (#8821)

same for issues8597,8669,8677.

FloEdelmann reacted with thumbs up emoji

@kirkwaiblinger
Copy link
MemberAuthor

@Eugeno

Yes, the premature merge was a tad unfortunate. Was amended in#9174, which went in before the release, though, so the only impact should be a small handful of slightly confusing release notes and issue/pr titles, but nothing overt to the user

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@StyleShitStyleShitStyleShit approved these changes

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Docs: Clarify purpose of no-useless-template-literal (or rename?)
5 participants
@kirkwaiblinger@JoshuaKGoldberg@Eugeno@StyleShit@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp