In#8740, new logic was added for template literals. This logic was wrongly added as a precondition, when it needs to be combined with the existingconst variable declaration logic.

Fix failing case fromBug: [no-unnecessary-type-assertion] (regression) false positives on template literals with no expressions #8819 by re-arranging conditions
The type assertions in thevalid tests added infix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside #8740 are actually unnecessary (but are too complex to be detected by the current logic). Changedconst tolet, so that the type assertions are truly necessary.
Improved the name ofisLiteralVariableDeclarationChangingTypeWithConst toisImplicitlyNarrowedConstDeclaration.

add failing tests

f53f6cd

Copy link

Contributor

typescript-eslintbot commentedApr 2, 2024

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 2, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`d8f2fe7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/660b661027b6d80008511550
😎 Deploy Preview	https://deploy-preview-8820--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 2, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd8f2fe7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

abrahamguo added2 commits

April 1, 2024 20:19

remove unrelated test, and implement fix

99a1a0b

clean up

a7255dd

abrahamguo marked this pull request as draft

April 2, 2024 01:29

abrahamguo marked this pull request as ready for review

April 2, 2024 01:34

abrahamguo added4 commits

April 1, 2024 20:35

improve name

5c856cd

clarify name and comment

e3f52f5

invert check

fc1fb1d

revert name

d8f2fe7

Copy link

codecovbot commentedApr 2, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base(a14ba9d) to head(d8f2fe7).
Report is 108 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #8820      +/-   ##==========================================- Coverage   88.02%   87.37%   -0.65%==========================================  Files         405      255     -150       Lines       14089    12510    -1579       Branches     4125     3927     -198     ==========================================- Hits        12402    10931    -1471+ Misses       1382     1304      -78+ Partials      305      275      -30