fix(typescript-estree): enable dot globs for project by default#8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:project-glob-dot-true

Apr 19, 2024

Merged

fix(typescript-estree): enable dot globs for project by default#8818

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:project-glob-dot-true

Apr 19, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedApr 1, 2024•
edited
Loading

BREAKING CHANGE: Changes the default glob settings for projects.

PR Checklist

Addresses an existing open issue:fixesBug: Hidden (dot) directories aren't globbed in typescript-estree's projects globs #6306
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Enablesdot: true.

Not sure if this should be a breaking change 🤔 but just to be safe, sending at thev8 branch.

💖

Copy link

Contributor

typescript-eslintbot commentedApr 1, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

fix(typescript-estree): enable dot globs for project by default

ad2f2e8

JoshuaKGoldberg force-pushed theproject-glob-dot-true branch fromaaea9ea toad2f2e8Compare

April 1, 2024 21:04

JoshuaKGoldberg changed the title~~Project glob dot true~~fix(typescript-estree): enable dot globs for project by default

Apr 1, 2024

Copy link

nx-cloudbot commentedApr 1, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitad2f2e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets