Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [explicit-function-return-type] fix checking wrong ancestor's return type#8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
auvred merged 5 commits intotypescript-eslint:mainfromyeonjuan:bugs/8808
Apr 20, 2024

Conversation

yeonjuan
Copy link
Contributor

…g ancestor's return type

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 31, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit44d9f3f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/662392b80aee45000847ac89
😎 Deploy Previewhttps://deploy-preview-8809--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 31, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit44d9f3f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@yeonjuanyeonjuan marked this pull request as ready for reviewApril 1, 2024 13:36
kirkwaiblinger
kirkwaiblinger previously approved these changesApr 19, 2024
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice! Makes sense to me!

thumbs up from borat

return true;
}
break;
return !!ancestor.typeAnnotation;

This comment was marked as resolved.

This comment was marked as resolved.

@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelApr 19, 2024
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool! 🔥

@codecovCodecov
Copy link

codecovbot commentedApr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base(5f38325) to head(00b1e57).

❗ Current head00b1e57 differs from pull request most recent head44d9f3f. Consider uploading reports for the commit44d9f3f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8809      +/-   ##==========================================- Coverage   88.05%   87.36%   -0.70%==========================================  Files         407      255     -152       Lines       14106    12495    -1611       Branches     4128     3921     -207     ==========================================- Hits        12421    10916    -1505+ Misses       1381     1304      -77+ Partials      304      275      -29
FlagCoverage Δ
unittest87.36% <100.00%> (-0.70%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts97.61% <100.00%> (-0.09%)⬇️

... and162 files with indirect coverage changes

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@auvredauvredauvred approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [explicit-function-return-type] false negatives on inner function when using allowTypedFunctionExpressions option
3 participants
@yeonjuan@kirkwaiblinger@auvred
[8]ページ先頭
©2009-2025 Movatter.jp