fix(eslint-plugin): no-unused-vars: mark declared statements as used#88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JamesHenry merged 1 commit intotypescript-eslint:masterfromarmano2:no-unused-vars

Jan 20, 2019

Merged

fix(eslint-plugin): no-unused-vars: mark declared statements as used#88

JamesHenry merged 1 commit intotypescript-eslint:masterfromarmano2:no-unused-vars

Jan 20, 2019

Conversation

Copy link

Collaborator

armano2 commentedJan 20, 2019

This PR adds logic to mark all declared Identifiers used forno-unused-vars

fixes:#61

fix(eslint-plugin): no-unused-vars: mark declared statements as used

70ed685

Copy link

codecovbot commentedJan 20, 2019•
edited
Loading

Codecov Report

Merging#88 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff            @@##           master     #88      +/-   ##=========================================+ Coverage    94.8%   94.8%   +<.01%=========================================  Files          48      48                Lines        2465    2466       +1       Branches      380     380              =========================================+ Hits         2337    2338       +1  Misses         77      77                Partials       51      51

Impacted Files	Coverage Δ
packages/eslint-plugin/lib/rules/no-unused-vars.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedbd27c5...70ed685. Read thecomment docs.

armano2 added enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule and removed enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labels

Jan 20, 2019