Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside#8740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

marcalexiei
Copy link
Contributor

@marcalexieimarcalexiei commentedMar 21, 2024•
edited
Loading

PR Checklist

Overview

no-unnecessary-type-assertion now avoids to removeconst casting from template literals when they are containing expressions.

This scenario is handled insideisConstVariableDeclaration which has been renamed toisLiteralVariableDeclarationChangingTypeWithConst to better reflect its purpose.

Edit: missed appreciation note... sorry
😅

JoshuaKGoldberg reacted with laugh emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@marcalexiei!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 21, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite29f5cf
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65fc8754f1e11200085205ea
😎 Deploy Previewhttps://deploy-preview-8740--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 21, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite29f5cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedMar 21, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base(59bbf41) to head(e29f5cf).

Additional details and impacted files
@@           Coverage Diff           @@##             main    #8740   +/-   ##=======================================  Coverage   87.38%   87.39%           =======================================  Files         254      254             Lines       12489    12492    +3       Branches     3919     3920    +1     =======================================+ Hits        10914    10917    +3  Misses       1304     1304             Partials      271      271
FlagCoverage Δ
unittest87.39% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts97.10% <100.00%> (+0.13%)⬆️

…t casting on template literals with expressions inside
@marcalexieimarcalexieiforce-pushed thefeature/template-literals-const branch from1ecaf50 toe29f5cfCompareMarch 21, 2024 19:15
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ha, tricky stuff - thanks!

And appreciated on the appreciation note. 😁

marcalexiei reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit2a62a40 intotypescript-eslint:mainMar 25, 2024
@marcalexieimarcalexiei deleted the feature/template-literals-const branchMarch 25, 2024 19:13
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull requestMar 27, 2024
yeonjuan pushed a commit to yeonjuan/typescript-eslint that referenced this pull requestMar 31, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-unnecessary-type-assertion] False positives for "as const" assertions with template literals
2 participants
@marcalexiei@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp