typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(typescript-estree): fix the issue of single run inferring in the pnpm repo (#3811)#8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromxqxian:fix/single-run-inferring-in-pnpm-repo

Mar 18, 2024

Merged

fix(typescript-estree): fix the issue of single run inferring in the pnpm repo (#3811)#8702

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromxqxian:fix/single-run-inferring-in-pnpm-repo

Mar 18, 2024

Conversation

Copy link

Contributor

xqxian commentedMar 17, 2024

PR Checklist

Addresses an existing open issue:fixesSupport pnpm for single run detection #3811
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Add a check for the eslint bin path in theinferSingleRun method within the pnpm repository.

Copy link

Contributor

typescript-eslintbot commentedMar 17, 2024

Thanks for the PR,@xqxian!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 17, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0aa1098`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65f74095c6767b0008385d92
😎 Deploy Preview	https://deploy-preview-8702--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

fix(typescript-estree): fix the issue of single run inferring in the …

0aa1098

…pnpm repo (typescript-eslint#3811)

xqxian force-pushed thefix/single-run-inferring-in-pnpm-repo branch fromdcc6a52 to0aa1098Compare

March 17, 2024 19:12

Copy link

nx-cloudbot commentedMar 17, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0aa1098. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedMar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base(3856c67) to head(0aa1098).

Additional details and impacted files

@@           Coverage Diff           @@##             main    #8702   +/-   ##=======================================  Coverage   88.10%   88.10%           =======================================  Files         402      402             Lines       14029    14031    +2       Branches     4117     4117           =======================================+ Hits        12360    12362    +2  Misses       1370     1370             Partials      299      299