Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): simplify playground logic#8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

I took a stab at simplifying the playground code a bit...open to feedback and further discussion 👍🏻

BenSievert reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 16, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit576e995
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/665d1a6ad312050008c6381a
😎 Deploy Previewhttps://deploy-preview-8686--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 16, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit576e995. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedMar 16, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base(2f02275) to head(81bd05a).

❗Current head81bd05a differs from pull request most recent head576e995

Pleaseupload reports for the commit576e995 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8686      +/-   ##==========================================- Coverage   88.12%   87.23%   -0.89%==========================================  Files         411      251     -160       Lines       14287    12334    -1953       Branches     4167     3881     -286     ==========================================- Hits        12590    10760    -1830+ Misses       1388     1305      -83+ Partials      309      269      -40
FlagCoverage Δ
unittest87.23% <ø> (-0.89%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 224 files with indirect coverage changes

@abrahamguoabrahamguo changed the titlePlaygroundchore (website): simplify playground logicMar 16, 2024
@abrahamguoabrahamguo changed the titlechore (website): simplify playground logicchore(website): simplify playground logicMar 16, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks a bit cleaner to me 🙂 thanks!

I think the root intent behind#7630 was to make thePlayground.tsx component a bit more split up even than this. But there's not much velocity in this area of code so I don't think it's super important that we keep iterating. This code reduction makes me happy.

Just requesting the one change on not calling theuseCallback hook inline.

Laila James opening a door and saying "this is nice"

abrahamguo reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJun 2, 2024
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelJun 3, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🧹 thanks!

abrahamguo reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitd4504c8 intotypescript-eslint:mainJun 3, 2024
61 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@armano2armano2Awaiting requested review from armano2

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Playground code refactor: Playground.tsx state switches
3 participants
@abrahamguo@armano2@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp