Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(parser): always enable comment, loc, range, tokens#8617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMar 7, 2024•
edited
Loading

BREAKING CHANGE: Changes opt-in options from@typescript-eslint/parser to always-on.

PR Checklist

Overview

Hardcodes those values totrue inparser, and sets up the types so that generated ASTs always have thecomment,range, andtokens.

Note that this doesn't change the values intypescript-estree. That package still has the genericAST type with conditional types on'comment' and'token'.

Adds some more unit tests while I'm in the area.

Co-authored-by:@bradzacher

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 7, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4332b9c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65eb38e0df28270007585dd3
😎 Deploy Previewhttps://deploy-preview-8617--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 7, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb8318a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat!(parser): always enable comment, loc, range, tokensfeat(parser): always enable comment, loc, range, tokensMar 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg added the breaking changeThis change will require a new major version to be released labelMar 7, 2024
programs?: Program[] | null;
project?: string[] | string | boolean | null;
projectFolderIgnoreList?: (RegExp | string)[];
range?: boolean;
projectFolderIgnoreList?: string[];
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I haven't verified yet (typescript-eslint/examples#9), but it looks to me like we never actually supported theRegExp case?

constprojectFolderIgnoreList=(
options.projectFolderIgnoreList??['**/node_modules/**']
)
.reduce<string[]>((acc,folder)=>{
if(typeoffolder==='string'){
acc.push(folder);
}
returnacc;
},[])

@codecovCodecov
Copy link

codecovbot commentedMar 8, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is80.00000% with4 lines in your changes are missing coverage. Please review.

Project coverage is 87.98%. Comparing base(f9520fe) to head(4332b9c).

❗ Current head4332b9c differs from pull request most recent headb8318a7. Consider uploading reports for the commitb8318a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##               v8    #8617      +/-   ##==========================================+ Coverage   87.33%   87.98%   +0.64%==========================================  Files         387      397      +10       Lines       13024    13881     +857       Branches     3771     4086     +315     ==========================================+ Hits        11375    12213     +838- Misses       1358     1368      +10- Partials      291      300       +9
FlagCoverage Δ
unittest87.98% <80.00%> (+0.64%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...pt-estree/src/parseSettings/createParseSettings.ts78.87% <80.00%> (ø)

... and98 files with indirect coverage changes

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneMar 8, 2024
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov8March 18, 2024 13:04
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamApril 22, 2024 21:21
@JoshuaKGoldbergJoshuaKGoldberg merged commit571bb9d intotypescript-eslint:v8Apr 26, 2024
54 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the parser-always-comments-etc branchApril 26, 2024 13:54
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Differentiate AST node types without parent (for estree) and with parent (for eslint)
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp