Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packages#8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Adds internal lint rule to look for flag relative imports that import code from other packages.

Found no existing violations! :)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 5, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite73995d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65e67828023cd5000877d3e0
😎 Deploy Previewhttps://deploy-preview-8596--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@kirkwaiblingerkirkwaiblinger changed the titleAdd internal lint rule no-relative-paths-to-internal-packagesfix(eslint-plugin-internal): Add internal lint rule no-relative-paths-to-internal-packagesMar 5, 2024
@kirkwaiblingerkirkwaiblinger changed the titlefix(eslint-plugin-internal): Add internal lint rule no-relative-paths-to-internal-packagesfix(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packagesMar 5, 2024
@nx-cloud
Copy link

nx-cloudbot commentedMar 5, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite73995d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx run integration-tests:test
✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.


import { createRule } from '../util';

export const REPO_ROOT = path.resolve(__dirname, '../../../..');
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

tried to import this from/packages/repo-tools/src/paths.mts but ts was upset about some module stuff that I didn't really understand.

JoshuaKGoldberg reacted with laugh emoji
@kirkwaiblingerkirkwaiblingerforce-pushed theno-internal-relative-paths branch from088d69b toe73995dCompareMarch 5, 2024 01:40
@codecov
Copy link

codecovbot commentedMar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base(6954a4a) to head(e73995d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8596      +/-   ##==========================================+ Coverage   87.12%   87.14%   +0.01%==========================================  Files         251      252       +1       Lines       12268    12287      +19       Branches     3868     3871       +3     ==========================================+ Hits        10689    10708      +19  Misses       1307     1307                Partials      272      272
FlagCoverage Δ
unittest87.14% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...rc/rules/no-relative-paths-to-internal-packages.ts100.00% <100.00%> (ø)

@kirkwaiblinger
Copy link
MemberAuthor

Not sure about the CI failure, but it appears to be failing on other recent PRs as well

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewMarch 5, 2024 01:55
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Michael Scott happily saying "I LOVE IT! I LOVE IT!"

kirkwaiblinger reacted with heart emoji
@JoshuaKGoldberg
Copy link
Member

Yeah, the integration tests are unrelated. This is great - thanks!

kirkwaiblinger reacted with heart emoji

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packagesfeat(eslint-plugin-internal): add internal lint rule no-relative-paths-to-internal-packagesMar 18, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit8b45691 intotypescript-eslint:mainMar 18, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 26, 2024
@kirkwaiblingerkirkwaiblinger deleted the no-internal-relative-paths branchAugust 28, 2024 05:23
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Internal linter rule for absolute imports from eslint packages

2 participants

@kirkwaiblinger@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp