#7693 is not reproduced. There was an error in tsconfig in playground. (#7693 (comment)). This PR adds test cases to prevent regression and ensure it.

test(eslint-plugin): [no-unnecessary-type-assertion] add tests with n…

68bfc8d

…oUncheckedIndexedAccess

Copy link

Contributor

typescript-eslintbot commentedFeb 29, 2024

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`95b6915`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e85dbc6ffd3d00082dc60e
😎 Deploy Preview	https://deploy-preview-8581--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 29, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit95b6915. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

yeonjuan force-pushed thefix/7693 branch from68bfc8d toec668e4Compare

March 1, 2024 07:39

set noUncheckedIndexedAccess false

0de2bb7

yeonjuan force-pushed thefix/7693 branch fromec668e4 to0de2bb7Compare

March 3, 2024 07:00

fixup

ac7c4bf

yeonjuan commented

Mar 3, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts

		@@ -6,13 +6,19 @@ import rule from '../../src/rules/no-unnecessary-type-assertion';
		const rootDir = path.resolve(__dirname, '../fixtures/');
		const ruleTester = new RuleTester({
		parserOptions: {
		EXPERIMENTAL_useProjectService: false,

Copy link

ContributorAuthor

yeonjuanMar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Without this,CI / Run Unit Tests with Experimental TSServer (eslint-plugin) (pull_request) failed

yeonjuan added2 commits

March 4, 2024 12:26

Merge branch 'main' into fix/7693

81c2a8f

Merge branch 'main' into fix/7693

95b6915

JoshuaKGoldberg approved these changes

Mar 18, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🧹 Thanks!

JoshuaKGoldberg merged commitd830364 intotypescript-eslint:main

Mar 18, 2024

github-actionsbot locked asresolvedand limited conversation to collaborators

Mar 26, 2024

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(eslint-plugin): [no-unnecessary-type-assertion] add tests with noUncheckedIndexedAccess#8581

test(eslint-plugin): [no-unnecessary-type-assertion] add tests with noUncheckedIndexedAccess#8581

Uh oh!