As mentioned in the linked issue,requireNullish: true wrongly disables all checking for this rule. This is because it mistakenly applies therequireNullish logic to both the left and right operands, rather than only the left.

abrahamguo added2 commits

February 26, 2024 22:02

ignore right

5c5a4c2

invert check

d74cc6c

Copy link

Contributor

typescript-eslintbot commentedFeb 27, 2024

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 27, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`15d7dbc`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66131281a8d8e2000859235e
😎 Deploy Preview	https://deploy-preview-8559--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 93 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 27, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit15d7dbc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedFeb 27, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base(716b783) to head(fd2b38f).
Report is 18 commits behind head on main.

❗ Current headfd2b38f differs from pull request most recent head15d7dbc. Consider uploading reports for the commit15d7dbc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #8559      +/-   ##==========================================- Coverage   88.02%   87.24%   -0.78%==========================================  Files         405      252     -153       Lines       14089    12344    -1745       Branches     4125     3882     -243     ==========================================- Hits        12402    10770    -1632+ Misses       1382     1305      -77+ Partials      305      269      -36

Flag	Coverage Δ
unittest	`87.24% <100.00%> (-0.78%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files	Coverage Δ
.../rules/prefer-optional-chain-utils/analyzeChain.ts	`100.00% <100.00%> (ø)`
...efer-optional-chain-utils/checkNullishAndReport.ts	`100.00% <100.00%> (ø)`
...efer-optional-chain-utils/gatherLogicalOperands.ts	`100.00% <ø> (ø)`
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	`97.61% <100.00%> (+0.05%)`	⬆️

... and176 files with indirect coverage changes

auvred requested changes

Feb 27, 2024

View reviewed changes

Copy link

Member

auvred left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I haven't looked deep into the source code of the rule yet, so I can't suggest any complete solutions. Requesting changes to prevent one potential bug and to improve the tests.

It also looks like you linked the wrong issue in the PR description. I believe you should link this one:#8487. Right?

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/gatherLogicalOperands.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/prefer-optional-chain/prefer-optional-chain.test.ts OutdatedShow resolvedHide resolved

auvred added the awaiting responseIssues waiting for a reply from the OP or another party label

Feb 27, 2024

abrahamguo added4 commits

February 27, 2024 07:12

invert

2e3eec3

add failing case

3e22435

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

08681ed

…refer-optional-chain

move operator check

14d3aeb

auvred requested changes

Feb 28, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/gatherLogicalOperands.ts OutdatedShow resolvedHide resolved

abrahamguo added12 commits

March 1, 2024 06:53

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

cece182

…refer-optional-chain

WIP

0e4fcf4

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

fe06a96

…refer-optional-chain

WIP

3969122

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

703b3c7

…refer-optional-chain

pull check out

d6ff24c

lint

2833796

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

52f9448

…refer-optional-chain

add tests

386d63c

add output

2738405

quotes

5e04ce9

finish tests

c9f0c62

abrahamguo requested a review fromJoshuaKGoldberg

March 12, 2024 12:22

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 12, 2024

abrahamguo requested a review fromauvred

March 12, 2024 12:38

auvred requested changes

Mar 12, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-optional-chain-utils/checkNullishAndReport.tsShow resolvedHide resolved

auvred added the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 12, 2024

abrahamguo added3 commits

March 12, 2024 23:04

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

4747282

…refer-optional-chain

remove last child

ed4aaa7

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

8b88d03

…refer-optional-chain

abrahamguo requested a review fromauvred

March 13, 2024 22:56

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 13, 2024

auvred requested changes

Mar 16, 2024

View reviewed changes

Copy link

Member

auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The overall code changes look great to me! Although, I haven't gotten deep enough into the rule code to 100% understand the logic yet. I'll try to take the time to figure out how it works internally, and then I can do a more thorough review 🙂

packages/eslint-plugin/src/rules/prefer-optional-chain.tsShow resolvedHide resolved

auvred added the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 16, 2024

abrahamguo added2 commits

March 16, 2024 08:35

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

606e1f6

…refer-optional-chain

add a few more tests

fd2b38f

abrahamguo requested a review fromauvred

March 16, 2024 13:41

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 16, 2024

bradzacher added the bugSomething isn't working label

Apr 4, 2024

auvred requested changes

Apr 6, 2024

View reviewed changes

Copy link

Member

auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly LGTM!

But there is conflict withmain branch inpackages/eslint-plugin/src/rules/prefer-optional-chain-utils/analyzeChain.ts file. Could you please resolve it?