fix(eslint-plugin): [no-misused-promises] improve check union types#8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/#8494

Feb 23, 2024

Merged

fix(eslint-plugin): [no-misused-promises] improve check union types#8534

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/#8494

Feb 23, 2024

Conversation

Copy link

Contributor

yeonjuan commentedFeb 22, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [no-misused-promises] Fails to check unions that contain misused promises. #8494
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(eslint-plugin): [no-misused-promises] improve check union types

4888a0d

Copy link

Contributor

typescript-eslintbot commentedFeb 22, 2024

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 22, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`a5c08f4`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65d8885e0926ef0008cde343
😎 Deploy Preview	https://deploy-preview-8534--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita5c08f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedFeb 22, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base(f825426) to head(a5c08f4).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #8534   +/-   ##=======================================  Coverage   86.89%   86.89%           =======================================  Files         250      250             Lines       12201    12202    +1       Branches     3852     3851    -1     =======================================+ Hits        10602    10603    +1  Misses       1332     1332             Partials      267      267