Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(typescript-estree): use simpler absolutify behavior for project service client file paths#8520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedFeb 20, 2024
edited
Loading

PR Checklist

Overview

Goes back to theabsolutify function behavior that was removed in#7752 for massing the provided client file paths.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 20, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit898b1df
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65d9edcc49654b0008384556
😎 Deploy Previewhttps://deploy-preview-8520--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 20, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit898b1df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedFeb 20, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is91.66667% with1 lines in your changes are missing coverage. Please review.

Project coverage is 87.84%. Comparing base(c1441c8) to head(898b1df).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8520      +/-   ##==========================================+ Coverage   86.88%   87.84%   +0.95%==========================================  Files         251      397     +146       Lines       12265    13844    +1579       Branches     3866     4073     +207     ==========================================+ Hits        10657    12161    +1504- Misses       1338     1381      +43- Partials      270      302      +32
FlagCoverage Δ
unittest87.84% <91.66%> (+0.95%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...escript-estree/src/useProgramFromProjectService.ts93.33% <91.66%> (+74.81%)⬆️

... and150 files with indirect coverage changes

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 21, 2024 01:50
bradzacher
bradzacher previously approved these changesFeb 23, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit5e7ec8f intotypescript-eslint:mainFeb 24, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the use-program-from-project-service-absolutify branchFebruary 25, 2024 21:42
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Performance regression from #7752 in project service due to changed file name casing
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp