Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(parser): support ecmaFeatures.jsx flag and tests#85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 3 commits intotypescript-eslint:masterfromarmano2:parser-options
Jan 20, 2019
Merged

feat(parser): support ecmaFeatures.jsx flag and tests#85

JamesHenry merged 3 commits intotypescript-eslint:masterfromarmano2:parser-options
Jan 20, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJan 20, 2019
edited
Loading

This PR contains changes fromeslint/typescript-eslint-parser#595 with small refactor propagating options

fixes:eslint/typescript-eslint-parser#594
fixes:#24

@armano2armano2 requested review frombradzacher anda team and removed request forbradzacherJanuary 20, 2019 01:58
@codecov
Copy link

codecovbot commentedJan 20, 2019
edited
Loading

Codecov Report

Merging#85 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff             @@##           master      #85      +/-   ##==========================================+ Coverage    94.8%   94.81%   +<.01%==========================================  Files          48       48                Lines        2465     2469       +4       Branches      380      381       +1     ==========================================+ Hits         2337     2341       +4  Misses         77       77                Partials       51       51
Impacted FilesCoverage Δ
packages/parser/src/parser.ts100% <100%> (ø)⬆️
packages/typescript-estree/src/parser.ts78.3% <100%> (-0.21%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecbb7ffe...1fe34b0. Read thecomment docs.

@armano2
Copy link
CollaboratorAuthor

should we warn users when options passed to parser are invalid?

@armano2armano2 changed the titlefeat(parser): validate options passed to parserfeat(parser): support ecmaFeatures.jsx flag and testsJan 20, 2019
@JamesHenryJamesHenry merged commitb321736 intotypescript-eslint:masterJan 20, 2019
@armano2armano2 deleted the parser-options branchJanuary 20, 2019 14:30
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parserOptions.ecmaFeatures.jsx option not passed to estree parserOptions.ecmaFeatures.jsx option not passed to estree
2 participants
@armano2@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp