Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(eslint-plugin): [no-misused-promises] add test cases for spread args#8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Implements the action items detailed in#5744 (comment).

Only functional change is to add test cases for the concern in the issue.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 16, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite174685
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65d8c92c9a943f000778f1de
😎 Deploy Previewhttps://deploy-preview-8493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 16, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite174685. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewFebruary 16, 2024 15:45
Comment on lines 677 to 675

if (anySignatureIsThenableType(checker, node, type)) {
return true;
}

return false;
return anySignatureIsThenableType(checker, node, type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#8534 is going to add support for unions. And it looks like it's going to make changes exactly on these very lines. So, to avoid merge conflicts, what do you think about reverting these changes in favor of#8534

kirkwaiblinger reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

makes sense! reverting and resolving conflicts

@kirkwaiblingerkirkwaiblingerforce-pushed the5744-misused-promises-spread-args branch fromaaca6ea to1cc86f3CompareFebruary 23, 2024 15:53
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 LGTM!

Aside: since this PR doesn't make any bug fixes, I think we should rename it fromfix(eslint-plugin): ... totest(eslint-plugin): .... What do you think?

kirkwaiblinger and JoshuaKGoldberg reacted with thumbs up emoji
@kirkwaiblingerkirkwaiblingerforce-pushed the5744-misused-promises-spread-args branch from1cc86f3 toe174685CompareFebruary 23, 2024 16:34
@kirkwaiblingerkirkwaiblinger changed the titlefix(eslint-plugin): [no-misused-promises] add test cases for spread argstest(eslint-plugin): [no-misused-promises] add test cases for spread argsFeb 23, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commitf2f57de intotypescript-eslint:mainFeb 24, 2024
@kirkwaiblingerkirkwaiblinger deleted the 5744-misused-promises-spread-args branchFebruary 24, 2024 17:33
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@auvredauvredauvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-misused-promises] An array of promises passed with spread (...args) syntax is not checked
3 participants
@kirkwaiblinger@auvred@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp