I noticed a broken link in the "Getting Started" page, specifically in the "Details" section under the recommended configurations link. It was pointing to localhost instead of the correct public domain.

I've updated the link to direct users to the correct destination.

As far as I can tell, there are no open issues related to this, and it's likely that no one has noticed the broken link yet.

This PR resolves the issue and ensures a smoother experience for users navigating the documentation.

Thanks for reviewing! 🚀

Corrected an invalid link directing to recommended configurations

e61ba4d

Corrects a broken link in the recommended configurations. Previously pointing to localhost, the link has been updated to the correct public host

Copy link

Contributor

typescript-eslintbot commentedFeb 14, 2024

Thanks for the PR,@salitha-pathi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 14, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c10fdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65cc69e00bc88b0008cf4f2e
😎 Deploy Preview	https://deploy-preview-8463--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 14, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc10fdc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedFeb 14, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(2b98ccd) 87.74% compared to head(e61ba4d) 86.94%.

❗ Current heade61ba4d differs from pull request most recent headc10fdc3. Consider uploading reports for the commitc10fdc3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #8463      +/-   ##==========================================- Coverage   87.74%   86.94%   -0.81%==========================================  Files         398      252     -146       Lines       13827    12251    -1576       Branches     4067     3861     -206     ==========================================- Hits        12133    10652    -1481+ Misses       1397     1332      -65+ Partials      297      267      -30

Flag	Coverage Δ
unittest	`86.94% <ø> (-0.81%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 146 files with indirect coverage changes

bradzacher approved these changes

Feb 14, 2024

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Huh how did that get in there! Thanks!!

bradzacher changed the title~~Docs: Fix broken link in getting started page details section~~docs: Fix broken link in getting started page details section

Feb 14, 2024

bradzacher mentioned this pull request

Feb 14, 2024

docs: updated Getting Started and related docs for flat config#8423

Merged

3 tasks

auvred requested changes

Feb 14, 2024

View reviewed changes

docs/Getting_Started.mdx Outdated

		@@ -72,7 +72,7 @@ The [`config`](./packages/TypeScript_ESLint.mdx) helper sets three parts of ESLi

		- [Parser](https://eslint.org/docs/latest/use/configure/parser): set to [`@typescript-eslint/parser`](./packages/Parser.mdx) so ESLint knows how to parse the new pieces of TypeScript syntax.
		- [Plugins](https://eslint.org/docs/latest/use/configure/plugins): set to [`@typescript-eslint/eslint-plugin`](./packages/ESLint_Plugin.mdx) to load [rules listed in our _Rules_ page](./Rules).
		- [Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our [recommended configuration](http://localhost:3000/linting/configs#recommended) to enable our most commonly useful lint rules.
		- [Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our [recommended configuration](https://typescript-eslint.io/linting/configs/#recommended) to enable our most commonly useful lint rules.

Copy link

Member

auvredFeb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	-[Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our[recommended configuration](https://typescript-eslint.io/linting/configs/#recommended) to enable our most commonly useful lint rules.
	-[Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our[recommended configuration](./linting/configs/#recommended) to enable our most commonly useful lint rules.

Let's update it to a relative path? This is a more flexible solution than a hard-coded URL. It will work correctly regardless of the domain name! For example, in Netlify Preview Deployments (preview deployment for this PR). What do you think?

bradzacher requested changes

Feb 14, 2024

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(can't edit the PR myself)

docs/Getting_Started.mdx Outdated

		@@ -72,7 +72,7 @@ The [`config`](./packages/TypeScript_ESLint.mdx) helper sets three parts of ESLi

		- [Parser](https://eslint.org/docs/latest/use/configure/parser): set to [`@typescript-eslint/parser`](./packages/Parser.mdx) so ESLint knows how to parse the new pieces of TypeScript syntax.
		- [Plugins](https://eslint.org/docs/latest/use/configure/plugins): set to [`@typescript-eslint/eslint-plugin`](./packages/ESLint_Plugin.mdx) to load [rules listed in our _Rules_ page](./Rules).
		- [Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our [recommended configuration](http://localhost:3000/linting/configs#recommended) to enable our most commonly useful lint rules.
		- [Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our [recommended configuration](https://typescript-eslint.io/linting/configs/#recommended) to enable our most commonly useful lint rules.

Copy link

Member

bradzacherFeb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	-[Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our[recommended configuration](https://typescript-eslint.io/linting/configs/#recommended) to enable our most commonly useful lint rules.
	-[Rules](https://eslint.org/docs/latest/use/configure/rules): extends from our[recommended configuration](./linting/configs/#recommended) to enable our most commonly useful lint rules.

Can you please use a relative link instead?

update to relative links

c10fdc3

bradzacher approved these changes

Feb 14, 2024

View reviewed changes

bradzacher changed the title~~docs: Fix broken link in getting started page details section~~docs: fix broken link in getting started page details section

Feb 14, 2024

bradzacher merged commit6a875b4 intotypescript-eslint:main

Feb 14, 2024